Skip to content

feat: implement issue #395 — Compliance: non-stub-dev-lead.yml #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 12 commits into from
Jun 10, 2026
Merged

feat: implement issue #395 — Compliance: non-stub-dev-lead.yml #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4aef27c
feat: implement issue #395 — Compliance: non-stub-dev-lead.yml
donpetry-bot Jun 8, 2026
f843380
chore: apply manual instructions [skip ci-relay]
donpetry-bot Jun 8, 2026
3290acd
fix(bot): address bot feedback [skip ci-relay]
donpetry-bot Jun 9, 2026
9c2df12
chore: apply manual instructions [skip ci-relay]
donpetry-bot Jun 9, 2026
e2116eb
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
f1d2218
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
781a275
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
ab5c1b0
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
1afd1c1
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
7458914
fix(bot): address bot feedback [skip ci-relay]
donpetry-bot Jun 10, 2026
b4e0d8d
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
ac0027b
Merge branch 'main' into dev-lead/issue-395-20260608-0054
don-petry Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 71 additions & 13 deletions .github/workflows/dev-lead-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ jobs:
TRIGGER_PHRASES: ${{ vars.TRIGGER_PHRASES || '@dev-lead' }}
DEV_LEAD_ENGINE: ${{ vars.DEV_LEAD_ENGINE || 'claude' }}
DEV_LEAD_DRY_RUN: ${{ vars.DEV_LEAD_DRY_RUN || 'false' }}
DEEP_TIMEOUT_SEC: ${{ vars.DEEP_TIMEOUT_SEC || '' }}
ACTION_TIMEOUT_SEC: ${{ vars.ACTION_TIMEOUT_SEC || '' }}
GH_TOKEN: ${{ secrets.GH_PAT_WORKFLOWS || github.token }}
GEMINI_CLI_TRUST_WORKSPACE: "true"
DEV_LEAD_SCRIPTS: .dev-lead/scripts
Expand Down Expand Up @@ -116,8 +118,11 @@ jobs:
prompts/dev-lead

- name: Protect dev-lead scripts from accidental git staging
run: echo ".dev-lead/" >> .gitignore

- name: Revert .gitignore changes before git operations
run: |
mkdir -p .git/info
git checkout .gitignore || true
echo ".dev-lead/" >> .git/info/exclude

- name: Classify event intent
Expand All @@ -142,6 +147,7 @@ jobs:
echo "INTENT_CHECKS=$(echo "$ctx" | jq -c '.checks // []')" >> "$GITHUB_ENV"
echo "INTENT_ISSUE_NUMBER=$(echo "$ctx" | jq -r '.issue_number // ""')" >> "$GITHUB_ENV"
echo "INTENT_ACTOR=$(echo "$ctx" | jq -r '.actor // ""')" >> "$GITHUB_ENV"
echo "INTENT_BODY=$(echo "$ctx" | jq -r '.body // ""')" >> "$GITHUB_ENV"

- name: Skip — log reason
if: env.INTENT_TYPE == 'skip'
Expand Down Expand Up @@ -188,7 +194,10 @@ jobs:
gh extension install github/gh-copilot || true
fi ;;
gemini)
npm install -g @google/gemini-cli || true ;;
npm install -g @google/gemini-cli || true
if ! gh copilot --version >/dev/null 2>&1; then
gh extension install github/gh-copilot || true
fi ;;
copilot)
npm install -g @google/gemini-cli || true
if ! gh copilot --version >/dev/null 2>&1; then
Expand All @@ -210,7 +219,10 @@ jobs:
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-ci.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-ci.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── fix-reviews ───────────────────────────────────────────────────────
- name: Run fix-reviews
Expand All @@ -226,7 +238,10 @@ jobs:
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-reviews.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-reviews.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── fix-bot-comment ───────────────────────────────────────────────────
- name: Run fix-bot-comment
Expand All @@ -236,12 +251,16 @@ jobs:
HEAD_SHA: ${{ env.INTENT_HEAD_SHA }}
REPO: ${{ github.repository }}
REVIEW_ENGINE: ${{ env.DEV_LEAD_ENGINE }}
COMMENT_BODY: ${{ env.INTENT_BODY }}
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-reviews.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-reviews.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── on-mention ─────────────────────────────────────────────────────────────
- name: Run on-mention
Expand All @@ -251,12 +270,16 @@ jobs:
HEAD_SHA: ${{ env.INTENT_HEAD_SHA }}
REPO: ${{ github.repository }}
REVIEW_ENGINE: ${{ env.DEV_LEAD_ENGINE }}
USER_INSTRUCTION: ${{ env.INTENT_BODY }}
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-reviews.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-reviews.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── review-changes ──────────────────────────────────────────────────────────
- name: Run review-changes
Expand All @@ -266,12 +289,16 @@ jobs:
HEAD_SHA: ${{ env.INTENT_HEAD_SHA }}
REPO: ${{ github.repository }}
REVIEW_ENGINE: ${{ env.DEV_LEAD_ENGINE }}
ACTOR: ${{ env.INTENT_ACTOR }}
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-reviews.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-reviews.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── issue ─────────────────────────────────────────────────────────────
- name: Run issue
Expand All @@ -285,7 +312,10 @@ jobs:
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-issue.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-issue.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── rebase ────────────────────────────────────────────────────────────
- name: Run rebase
Expand All @@ -299,7 +329,10 @@ jobs:
GEMINI_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
COPILOT_GITHUB_TOKEN: ${{ secrets.GH_PAT }}
PROMPTS_DIR: .dev-lead/prompts/dev-lead
run: bash .dev-lead/scripts/dev-lead-fix-reviews.sh
run: |
bash .dev-lead/scripts/dev-lead-fix-reviews.sh || rc=$?
[ "${rc:-0}" -eq 2 ] && exit 0
exit "${rc:-0}"

# ── enable-auto-merge ─────────────────────────────────────────────────
# Triggered when a trusted bot approves a PR. Skips engine install and
Expand Down Expand Up @@ -333,20 +366,43 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
permissions:
contents: read
contents: write
pull-requests: read

steps:
- name: Check for associated non-fork PR
id: check-pr
env:
GH_TOKEN: ${{ secrets.GH_PAT_WORKFLOWS || github.token }}
CHECK_RUN_PRS: ${{ toJson(github.event.check_run.pull_requests) }}
CHECK_RUN_HEAD_SHA: ${{ github.event.check_run.head_sha }}
REPO_FULL_NAME: ${{ github.repository }}
run: |
set -euo pipefail
pr_count=$(echo "$CHECK_RUN_PRS" | jq 'length')
if [ "$pr_count" -eq 0 ]; then
echo "::notice::check_run has no associated PRs — skipping relay"
echo "should_relay=false" >> "$GITHUB_OUTPUT"
# GitHub App check_runs (SonarCloud, external CodeQL gates, etc.) do not
# populate check_run.pull_requests. Fall back to the commits-to-pulls API.
echo "::notice::check_run.pull_requests is empty — trying commits-to-pulls API fallback for SHA ${CHECK_RUN_HEAD_SHA}"
pulls_json=$(gh api \
-H "Accept: application/vnd.github+json" \
"repos/${REPO_FULL_NAME}/commits/${CHECK_RUN_HEAD_SHA}/pulls" 2>/dev/null || echo "[]")
Comment thread
don-petry marked this conversation as resolved.
open_pulls=$(echo "$pulls_json" | jq '[.[] | select(.state=="open")]')
pr_count=$(echo "$open_pulls" | jq 'length')
if [ "$pr_count" -eq 0 ]; then
echo "::notice::No open PRs found for commit ${CHECK_RUN_HEAD_SHA} — skipping relay"
echo "should_relay=false" >> "$GITHUB_OUTPUT"
exit 0
fi
head_repo_full=$(echo "$open_pulls" | jq -r '.[0].head.repo.full_name // empty')
if [ -n "$head_repo_full" ] && [ "$head_repo_full" != "$REPO_FULL_NAME" ]; then
echo "::notice::Commit ${CHECK_RUN_HEAD_SHA} belongs to fork (${head_repo_full}) — skipping relay"
echo "should_relay=false" >> "$GITHUB_OUTPUT"
exit 0
fi
pr_number=$(echo "$open_pulls" | jq -r '.[0].number')
echo "should_relay=true" >> "$GITHUB_OUTPUT"
echo "pr_number=$pr_number" >> "$GITHUB_OUTPUT"
exit 0
fi
head_repo_url=$(echo "$CHECK_RUN_PRS" | jq -r '.[0].head.repo.url // empty')
Expand All @@ -367,6 +423,7 @@ jobs:
RELAY_PR_NUMBER: ${{ steps.check-pr.outputs.pr_number }}
RELAY_HEAD_SHA: ${{ github.event.check_run.head_sha }}
RELAY_REPO: ${{ github.repository }}
RELAY_CHECK_ID: ${{ github.event.check_run.id }}
RELAY_CHECK_NAME: ${{ github.event.check_run.name }}
RELAY_CONCLUSION: ${{ github.event.check_run.conclusion }}
RELAY_DETAILS_URL: ${{ github.event.check_run.details_url }}
Expand All @@ -377,11 +434,12 @@ jobs:
--argjson pr_number "$RELAY_PR_NUMBER" \
--arg head_sha "$RELAY_HEAD_SHA" \
--arg repo "$RELAY_REPO" \
--argjson check_id "$RELAY_CHECK_ID" \
--arg name "$RELAY_CHECK_NAME" \
--arg conclusion "$RELAY_CONCLUSION" \
--arg details_url "$RELAY_DETAILS_URL" \
--arg app_slug "$RELAY_APP_SLUG" \
'{event_type:"dev-lead-ci-failure",client_payload:{pr_number:$pr_number,head_sha:$head_sha,repo:$repo,checks:[{name:$name,conclusion:$conclusion,details_url:$details_url,app_slug:$app_slug}]}}')
'{event_type:"dev-lead-ci-failure",client_payload:{pr_number:$pr_number,head_sha:$head_sha,repo:$repo,checks:[{id:$check_id,name:$name,conclusion:$conclusion,details_url:$details_url,app_slug:$app_slug}]}}')
echo "$payload" | gh api \
--method POST "repos/$RELAY_REPO/dispatches" --input -
echo "::notice::Relayed CI failure for PR $RELAY_PR_NUMBER"
Loading
Loading