Skip to content

fix(dev-lead): resolve outdated comments in both applied and no-changes paths #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 3 commits into from
May 30, 2026
Merged

fix(dev-lead): resolve outdated comments in both applied and no-changes paths #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
768d8e1
fix: pin GitHub Actions to specific commit SHAs per compliance standard
don-petry May 27, 2026
bbb6ee4
fix(dev-lead): resolve outdated comments in both applied and no-chang…
May 30, 2026
8e77d94
fix(ci): correct invalid GitHub Actions cache SHA in daily-pr-review-…
May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/daily-pr-review-health.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
node-version: '20'

- name: Cache claude-code CLI
uses: actions/cache@v5.0.5
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
with:
path: ~/.npm-global
key: claude-code-${{ env.CLAUDE_CODE_VERSION }}-${{ runner.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/repair-pr-approvals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v6.0.2
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Repair PR approvals
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v6.0.2
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Run copilot_chat tests
run: bash tests/test_copilot_chat.sh
Expand Down
6 changes: 3 additions & 3 deletions scripts/dev-lead-fix-reviews.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,9 +542,9 @@ case "$INTENT_TYPE" in
post_reviews_terminal "fix-reviews" "applied" "Changes committed and pushed."
else
notify_coderabbit_resolve
resolve_actor_outdated_threads "fix-reviews"
post_no_changes "fix-reviews"
fi
resolve_actor_outdated_threads "fix-reviews"
try_enable_auto_merge
fi
exit "$rc"
Expand All @@ -561,9 +561,9 @@ case "$INTENT_TYPE" in
post_reviews_terminal "fix-bot-comment" "applied" "Changes committed and pushed."
else
notify_coderabbit_resolve
resolve_actor_outdated_threads "fix-bot-comment"
post_no_changes "fix-bot-comment"
fi
resolve_actor_outdated_threads "fix-bot-comment"
try_enable_auto_merge
fi
exit "$rc"
Expand Down Expand Up @@ -613,9 +613,9 @@ case "$INTENT_TYPE" in
post_reviews_terminal "review-changes" "applied" "Changes committed and pushed."
else
notify_coderabbit_resolve
resolve_actor_outdated_threads "review-changes"
post_reviews_terminal "review-changes" "no-changes" "No changes were needed for this PR."
fi
resolve_actor_outdated_threads "review-changes"
try_enable_auto_merge
fi
exit "$rc"
Expand Down
41 changes: 41 additions & 0 deletions tests/dev-lead/unit/test_fix_reviews.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,3 +877,44 @@ STUB

[[ "$output" == *"ACTOR not set for intent=fix-reviews"* ]]
}

# ── resolve_actor_outdated_threads: called in both branches ─────────────────

@test "fix-reviews: resolve_actor_outdated_threads called in applied path (dry-run)" {
export INTENT_TYPE="fix-reviews"
export DEV_LEAD_DRY_RUN="true"
export ACTOR="chatgpt-codex-connector[bot]"

run bash "$FIX_REVIEWS_SCRIPT"

[ "$status" -eq 0 ]
# In dry-run, resolve_actor_outdated_threads should announce it would resolve
[[ "$output" == *"would resolve outdated review threads authored by chatgpt-codex-connector[bot]"* ]]
}
Comment on lines +883 to +893

@test "fix-bot-comment: resolve_actor_outdated_threads called in applied path (dry-run)" {
export INTENT_TYPE="fix-bot-comment"
export DEV_LEAD_DRY_RUN="true"
export ACTOR="sonarqubecloud[bot]"
export COMMENT_BODY="SonarQube found issues"

run bash "$FIX_REVIEWS_SCRIPT"

[ "$status" -eq 0 ]
# Should call resolve_actor_outdated_threads in dry-run mode
[[ "$output" == *"would resolve outdated review threads authored by sonarqubecloud[bot]"* ]]
}
Comment on lines +895 to +906

@test "review-changes: resolve_actor_outdated_threads called in applied path (dry-run)" {
export INTENT_TYPE="review-changes"
export DEV_LEAD_DRY_RUN="true"
export ACTOR="donpetry"
export PR_TITLE="Test PR"
export PR_DESCRIPTION="A test PR"

run bash "$FIX_REVIEWS_SCRIPT"

[ "$status" -eq 0 ]
# Should call resolve_actor_outdated_threads in dry-run mode
[[ "$output" == *"would resolve outdated review threads authored by donpetry"* ]]
}
Comment on lines +908 to +920
Loading