Skip to content

chore: follow the GitHub App renames (petry-projects-* → combsmith-*) - #2333

Merged
don-petry merged 1 commit into
mainfrom
chore/combsmith-app-slugs
Oct 14, 2026
Merged

don-petry merged 1 commit into
mainfrom
chore/combsmith-app-slugs

Conversation

@don-petry

@don-petry don-petry commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

The petry-projects-planner, petry-projects-release-manager and petry-projects-dependabot-automrg GitHub Apps were renamed to combsmith-* (their slugs and bot logins changed with them). Workflows authenticate by App ID, so this only updates the names: docs, comments, and in .github-private the PR-budget mechanical-login default and its tests.

5 files changed, 14 insertions(+), 14 deletions(-)

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

The planner, release-manager and dependabot-automrg Apps were renamed; their slugs and bot logins are now combsmith-*. Workflows find the Apps by App ID, so this updates names in docs, comments, the PR-budget mechanical-login default and its tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 14, 2026 21:53
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 99b28a26-35d5-4261-b14f-c2fd5fe4df70
📥 Commits

Reviewing files that changed from the base of the PR and between fcc5197 and b77f313.

📒 Files selected for processing: 5
  • .github/workflows/add-to-project.yml
  • AGENTS.md
  • docs/release/runbook.md
  • scripts/lib/pr-automation-budget.sh
  • tests/test_pr_automation_budget.bats
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

QA Lead — test-risk advisory

Risk tier: LOW. This is a rename of names only, and the only line that runs is the PR_BUDGET_MECHANICAL_LOGINS default. If that value is wrong, the Dependabot merge bot's events get counted against the PR budget. Nothing breaks, so it fails safe.

What I'd shore up (highest leverage first):

  • The tests can't catch a wrong login. AUTOMRG and the bd176 fixture were renamed together with the default, so the suite passes whatever the string is. Before merge, check that the real bot login is exactly combsmith-dependabot-automrg[bot]. It's a truncated slug, so look at a recent Dependabot PR's reviews or the App page. Don't take it from the PR text.
  • Add a negative test that petry-projects-dependabot-automrg[bot] is no longer marked mechanical on a Dependabot PR. This is the half the rename doesn't cover. It also makes you decide whether old events on PRs still in flight need a grace period. They probably don't, because GitHub reports a renamed bot under its current login.
  • The bd176 fixture is a record of a real PR, and its logins have now been changed. Add a one-line comment saying they were renamed, so nobody takes the fixture as the literal capture.
  • Optional and cheap: a CI grep guard that fails if petry-projects-(planner|release-manager|dependabot-automrg) shows up again.

Escalate? no

Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture
(bmad-tea v1.19.0). Opt out on this item with the qa-lead:hands-off label.

@don-petry
don-petry merged commit e43ff1a into main Oct 14, 2026
67 of 71 checks passed
@don-petry
don-petry deleted the chore/combsmith-app-slugs branch October 14, 2026 21:59
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-14T23:03:12Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants