Skip to content

feat: implement issue #1995 — info_status_pattern covers only SonarCloud — Codex/Qodo/CodeRabbit usage-limit notices are still undispositionable and still strand PRs #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 10 commits into from
Oct 1, 2026
Merged

feat: implement issue #1995 — info_status_pattern covers only SonarCloud — Codex/Qodo/CodeRabbit usage-limit notices are still undispositionable and still strand PRs #2000

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fcbd1c6
feat: implement issue #1995 — info_status_pattern covers only SonarCl…
don-petry Oct 1, 2026
9b79eab
fix(reviews): address review comments [skip ci-relay]
don-petry Oct 1, 2026
5861a57
fix(reviewer-sources): anchor the Codex usage-limit pattern to the bo…
Oct 1, 2026
69487ef
Merge branch 'main' into dev-lead/issue-1995-20261001-1858
don-petry Oct 1, 2026
84e7fc5
fix(reviewer-sources): end-anchor the Codex notice pattern; negatives…
Oct 1, 2026
6f05785
fix(reviewer-sources): start-anchor the CodeRabbit and Qodo notice pa…
Oct 1, 2026
769f3dd
Merge main (#2003) into #1995's branch: resolve reviewer-sources.tsv
Oct 1, 2026
1b86c65
fix(info-status): bot path checks the body; patterns match complete n…
Oct 1, 2026
7138005
test(resolve-comment): fake gh bodies carry real newlines
Oct 1, 2026
2c77e41
Merge main into #2000 after #1998 squash
Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/dev-lead/unit/test_maintainer_resolve_comment.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ _mrc_minimized_reason() {
# whose login happens to equal a registered bot login (e.g. a user account named
# `sonarqubecloud`) must be refused like any other human — never minimized.
# A SonarCloud clean-status body that matches its registered info_status_pattern.
SONAR_PASS_JSON_BODY='**Quality Gate passed**\\n[0 New issues]\\n[0 Security Hotspots]'
SONAR_PASS_JSON_BODY='**Quality Gate passed**\n[0 New issues]\n[0 Security Hotspots]'

_mrc_fake_gh() {
# $1 = author __typename, $2 = author login (default sonarqubecloud), $3 = the
Expand Down Expand Up @@ -335,7 +335,7 @@ SHIM
}

@test "#1995: a SonarCloud 'Quality Gate failed' comment is refused on the bot path" {
_mrc_fake_gh Bot sonarqubecloud '**Quality Gate failed**\\n[3 New issues]'
_mrc_fake_gh Bot sonarqubecloud '**Quality Gate failed**\n[3 New issues]'
run bash "$MRC" "IC_kwDOfake1" --reason "status only"
[ "$status" -eq 3 ]
[ ! -s "$BATS_TEST_TMPDIR/gh-writes.log" ]
Expand Down
Loading