Repository navigation
chore: sync 4 org-standard workflow stub(s) from petry-projects/.github #1819
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,11 +47,11 @@ | |
| add-to-project: | ||
| permissions: | ||
| contents: read | ||
| uses: petry-projects/.github/.github/workflows/add-to-project-reusable.yml@add-to-project/v1-next # NOSONAR(githubactions:S7637) first-party channel ref | ||
| with: | ||
| project_id: PVT_kwDOD2inqs4BZq3- | ||
| project_url: https://github.com/orgs/petry-projects/projects/1 | ||
| agent_ref: add-to-project/v1-next | ||
|
Comment on lines
+50
to
+54
There was a problem hiding this comment. Suggestion: This moves the caller and forwarded Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** .github/workflows/add-to-project.yml
**Line:** 50:54
**Comment:**
*Api Mismatch: This moves the caller and forwarded `agent_ref` from the required stable channel to `next`, so stable-channel promotions and rollbacks no longer control this workflow.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Collaborator
Author
There was a problem hiding this comment. Fixed in .github/workflows/add-to-project.yml: reverted both the
coderabbitai[bot] marked this conversation as resolved.
|
||
| # Pass only the secrets the reusable declares (least privilege; avoids | ||
| # `secrets: inherit` handing the reusable every org secret). | ||
| secrets: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,4 +30,4 @@ | |
|
|
||
| jobs: | ||
| agent-shield: | ||
| uses: petry-projects/.github/.github/workflows/agent-shield-reusable.yml@agent-shield/v2-next # NOSONAR(githubactions:S7637) first-party channel ref | ||
|
Collaborator
Author
There was a problem hiding this comment. Skipping the SHA-pin request: this There was a problem hiding this comment. Suggestion: This changes the required AgentShield caller from the canonical stable channel to Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** .github/workflows/agent-shield.yml
**Line:** 33:33
**Comment:**
*Api Mismatch: This changes the required AgentShield caller from the canonical stable channel to `next`, causing CI to use unreleased scan behavior and failing the repository's canonical stub validation.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Collaborator
Author
There was a problem hiding this comment. Fixed in .github/workflows/agent-shield.yml: reverted the AgentShield reusable
coderabbitai[bot] marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # ───────────────────────────────────────────────────────────────────────────── | ||
| # Dev-Lead Agent — thin caller stub | ||
| # Standard: petry-projects/.github/standards/ci-standards.md#5-dev-lead-agent | ||
|
|
@@ -67,9 +67,9 @@ | |
| # Promotion is done by moving the channel tags centrally; this | ||
| # caller is never edited on release. agent_ref threads the same channel into | ||
| # dev-lead's own scripts/prompts checkout. See https://github.com/petry-projects/.github/blob/main/standards/ci-standards.md#dev-lead-agent. | ||
| uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@dev-lead/v139-next # NOSONAR(githubactions:S7637) first-party channel ref | ||
|
Collaborator
Author
There was a problem hiding this comment. Skipping the SHA-pin request: this |
||
| with: | ||
| agent_ref: dev-lead/v139-next | ||
|
Comment on lines
+70
to
+72
There was a problem hiding this comment. Suggestion: The dev-lead reusable and Assessment: 🔴
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** .github/workflows/dev-lead.yml
**Line:** 70:72
**Comment:**
*State Lifecycle: The dev-lead reusable and `agent_ref` now use `next`, rearming the self-hosting circular dependency that SC2 requires this workflow to avoid.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Collaborator
Author
There was a problem hiding this comment. Fixed in .github/workflows/dev-lead.yml: reverted both the
coderabbitai[bot] marked this conversation as resolved.
|
||
| secrets: inherit # NOSONAR(githubactions:S7635) first-party trusted reusable | ||
| permissions: | ||
| contents: write | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping the SHA-pin request: this
uses:reference targets one of the org's own reusable workflows on a moving release-channel tag (@<agent>/v<MAJOR>-<tier>), which is the sanctioned first-party mutable-ref exception per AGENTS.md ("Release channel tags & the mutable-ref exception"). Pinning it to a commit SHA would freeze it off the central rollout/rollback mechanism and is rejected by the reusable-pin compliance audit, so the ref is intentionally left on its channel tag. Note: the flagged-nextrefs have separately been reverted to their canonical-stablechannel in this pass.