Skip to content

feat: implement issue #1394 — Compliance: gitignore_baseline - #1395

Merged
don-petry merged 3 commits into
mainfrom
dev-lead/issue-1394-20260731-1421
Aug 2, 2026
Merged

don-petry merged 3 commits into
mainfrom
dev-lead/issue-1394-20260731-1421

Conversation

@don-petry

@don-petry don-petry commented Jul 31, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1394

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated repository ignore rules to exclude additional development tools, archives, and workspace files.

@don-petry
don-petry requested a review from a team as a code owner July 31, 2026 14:25
@codeant-ai

codeant-ai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 0a776ed Jul 31, 2026 · 14:25 14:26

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 70b37369-6a4c-42db-b931-067aeb6ad271

📥 Commits

Reviewing files that changed from the base of the PR and between 0a776ed and 061f27d.

📒 Files selected for processing (1)
  • .gitignore
📝 Walkthrough

Walkthrough

The .gitignore ignore policy now includes .dev-lead/, actionlint, and actionlint.tar.gz. It no longer ignores .claude/scheduled_tasks.lock.

Changes

Gitignore policy

Layer / File(s) Summary
Update ignored development artifacts
.gitignore
The ignore rules add .dev-lead/, actionlint, and actionlint.tar.gz. The .claude/scheduled_tasks.lock rule is removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR changes .gitignore, but the summary does not confirm that the canonical secrets-baseline block was copied verbatim. Verify the designated secrets-baseline markers, canonical content, and resulting hash against the organization standard.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the implementation of issue #1394 and the gitignore compliance change.
Out of Scope Changes check ✅ Passed All reported changes are limited to .gitignore updates and relate to the stated compliance objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-1394-20260731-1421

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Compliance: extend gitignore baseline for agent worktrees and CI artifacts

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Expand the repo-wide compliance .gitignore baseline for agent/local worktrees.
• Ignore CI-generated actionlint binaries to prevent accidental commits.
• Add a dedicated ignore entry for the dev-lead agent workspace directory.
High-Level Assessment

The following are alternative approaches to this PR:

1. Use a global Git excludes file (core.excludesFile)
  • ➕ Avoids repo churn when updating local/agent ignore patterns
  • ➕ Keeps repo .gitignore smaller
  • ➖ Not enforced across contributors/CI; compliance baseline wouldn’t be guaranteed
  • ➖ Harder to audit in-repo policy adherence
2. Generate .gitignore from a shared org template in CI
  • ➕ Centralizes policy and ensures consistent baseline across repos
  • ➕ Reduces manual edits and drift
  • ➖ Adds CI complexity and requires a generation/verification step
  • ➖ May conflict with repo-specific ignore needs unless carefully layered

Recommendation: Keep the in-repo .gitignore updates as implemented: it best satisfies the stated compliance requirement (baseline ignore rules enforced in every repo). The alternatives either weaken enforcement (global excludes) or add additional operational complexity (template generation) that likely isn’t justified for a small baseline extension.

Files changed (1) +6 / -2

Other (1) +6 / -2
.gitignoreAdd ignore rules for agent workspaces and CI-downloaded actionlint +6/-2

Add ignore rules for agent workspaces and CI-downloaded actionlint

• Updates the compliance baseline section to include a dev-lead agent workspace directory and to ignore CI-generated actionlint artifacts (binary and tarball). Also adjusts the section header to reflect CI-generated tool artifacts.

.gitignore

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the baseline .gitignore file to ignore .dev-lead/ worktrees and CI-generated actionlint artifacts, while removing .claude/scheduled_tasks.lock. The reviewer noted that adding build/tool artifacts like actionlint violates the secrets-only design scope of this baseline file, and recommended removing them and reverting the section header change.

Comment thread .gitignore Outdated
Comment thread .gitignore Outdated
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #1395
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-31T14:57:56Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-31T14:57:56Z

@don-petry
don-petry enabled auto-merge (squash) July 31, 2026 14:28
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 31, 2026
@qodo-code-review

qodo-code-review Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 48 rules

Grey Divider


Remediation recommended

1. Overbroad actionlint ignore ✓ Resolved 🐞 Bug ⚙ Maintainability
Description
The newly added ignore patterns actionlint and actionlint.tar.gz are not root-anchored, so they
will ignore files with those names anywhere in the repo, despite the comment stating the artifacts
are downloaded into the repo root. This can cause unrelated nested files (e.g., tools/actionlint)
to be silently ignored and missed in normal git status workflows.
Code

.gitignore[R390-393]

+# CI downloads actionlint into the repo root during linting; ignore the
+# generated binary so local lint runs cannot accidentally commit it.
+actionlint
+actionlint.tar.gz
Relevance

●●● Strong

Team often tightens unanchored ignore/allowlist patterns to avoid unintended suppression;
root-anchoring is a trivial fix.

PR-#477
PR-#155

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The added comment says the artifacts are downloaded into the repo root, but the patterns are
unanchored (no leading /). Elsewhere in the same file, root-only tool binaries are ignored with a
leading slash (/gitleaks), showing the intended convention for root-scoped ignores.

.gitignore[380-393]
.gitignore[404-408]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
New `.gitignore` entries for `actionlint` artifacts are intended to ignore files downloaded into the repo root, but the patterns are not anchored. Without a leading `/`, Git will ignore matches at any directory depth, which can unintentionally ignore legitimate nested files named `actionlint`.

## Issue Context
The comment explicitly says the artifacts are downloaded into the repo root. The file already uses root-anchored ignores for similar CI-downloaded binaries (e.g., `/gitleaks`).

## Fix Focus Areas
- .gitignore[390-393]
- .gitignore[407-408]

## Suggested change
Change:
- `actionlint` -> `/actionlint`
- `actionlint.tar.gz` -> `/actionlint.tar.gz`

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

Comment thread .gitignore Outdated
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-31T15:32:37Z.

@don-petry
don-petry disabled auto-merge July 31, 2026 14:35
donpetry-bot
donpetry-bot previously approved these changes Jul 31, 2026

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 0a776ed40ac7376189487e5d01d0c19bdb0c7469
Cascade: triage → audit (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5)

Summary

The PR re-syncs the org-managed L1 secrets-baseline block in .gitignore to the canonical source in petry-projects/.github. I extracted the managed block from the canonical repo, the PR base, and the PR head: base hash (78f2f7a7...) differs from canonical (confirming the drift reported by issue #1394), while the PR head block is byte-for-byte identical to canonical (SHA-256 61b7fb3b... on both). The base-to-canonical delta is exactly the PR diff, so this is precisely the 're-copy verbatim' remediation the issue prescribes. The scope objections from gemini/triage/deep review are based on the pre-drift header; the canonical baseline itself contains the new section-13 header, .dev-lead/, and actionlint entries, and the org standard explicitly says the baseline 'also includes standard agent worktrees and CI tool artifacts per organization coding policy.' No secrets in the diff, no negation-discipline changes, nothing above the BEGIN marker, L2 untouched; gitleaks, CodeQL, SonarCloud, and ShellCheck are green.

Findings

  • INFO: Verified by SHA-256 comparison: PR head managed block is byte-for-byte identical to the canonical L1 baseline in petry-projects/.github/.gitignore; base branch block differed (the drift issue #1394 flagged). PR is the exact prescribed remediation.
  • INFO: Gemini's advisory recommendation (remove actionlint entries, revert section-13 header) would re-introduce the canonical-hash drift and re-open the compliance finding. The correct resolution is to keep the block verbatim; consider replying to the bot thread noting the canonical source includes these lines.
  • INFO: Ignoring CI-downloaded binaries (actionlint, actionlint.tar.gz) is a mild supply-chain positive: it prevents accidental commits of unreviewed binaries. No negation (!) patterns were touched, so no secret-allow rules are affected.

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: opus 4.8 + duck: o4-mini → audit: fable 5). Reply if you need a human review.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry dismissed stale reviews from donpetry-bot and coderabbitai[bot] via 82beefa July 31, 2026 14:38
@don-petry
don-petry enabled auto-merge (squash) July 31, 2026 14:38
@don-petry
don-petry disabled auto-merge July 31, 2026 14:39
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #1395
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-31T15:11:18Z

@don-petry
don-petry enabled auto-merge (squash) July 31, 2026 14:41
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge July 31, 2026 14:42
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 31, 2026 14:43
@donpetry-bot donpetry-bot added the needs-human-review Flagged by automated PR review agent label Jul 31, 2026
@donpetry-bot
donpetry-bot requested a review from a team July 31, 2026 14:46
@don-petry
don-petry disabled auto-merge August 2, 2026 01:04
@don-petry
don-petry merged commit 367a4bb into main Aug 2, 2026
29 of 30 checks passed
@don-petry
don-petry deleted the dev-lead/issue-1394-20260731-1421 branch August 2, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human-review Flagged by automated PR review agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: gitignore_baseline

2 participants