Repository navigation
feat: implement issue #1098 — [Phase 2] Wire claude-sonnet-5 into the Claude model chains as a candidate - #1115
Conversation
… Claude model chains as a candidate
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
There was a problem hiding this comment.
Code Review
This pull request adds claude-sonnet-5-0 as a fallback candidate to the Claude triage and deep model chains, and registers it in the known engines list. It also includes unit tests to verify the updated chains, fallback behavior under rate-limiting, and that the action chain remains unaffected. There are no review comments, so I have no feedback to provide.
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
Pull request overview
Wires claude-sonnet-5-0 into the Claude in-engine fallback chains (as a non-default fallback candidate) and extends validation/tests so the harness can walk to Sonnet 5 under Claude rate-limit conditions without altering overall engine architecture.
Changes:
- Append
claude-sonnet-5-0toCLAUDE_TRIAGE_MODEL_CHAINandCLAUDE_DEEP_MODEL_CHAINdefaults (leaving action/audit/single unchanged). - Extend
tests/dev-lead/unit/test_engine_chain.batsto assert the new chain contents and the rate-limit walk reaching Sonnet 5. - Add
claude-sonnet-5-0toscripts/aw.sh’sknown_enginesallowlist to keepaw compilewarning-free for workflows that pin it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/engine.sh | Appends Sonnet 5 to Claude triage/deep fallback chains as a candidate. |
| scripts/aw.sh | Adds Sonnet 5 engine id to the aw compile known-engines warning suppressor set. |
| tests/dev-lead/unit/test_engine_chain.bats | Adds unit tests asserting the new chain membership and fallback-walk behavior. |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
|
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 8718170b5624adcfb48e42f347749f04850ec21c
Review mode: triage-approved (single reviewer)
Summary
Config-only change appending claude-sonnet-5-0 as a fallback candidate after sonnet-4-6 in the Claude triage and deep model chains, updating ENGINE_LABEL, and adding the id to aw.sh known_engines. All 6 acceptance criteria of #1098 are met, the single prior review finding (stale ENGINE_LABEL) was fixed at the head commit with the thread resolved, and all CI checks are green. Confirms the triage low-risk assessment.
Linked issue analysis
Issue #1098 asks to wire claude-sonnet-5 into the Claude chains as a candidate (not fleet default). Verified against each AC: (1) triage/deep chains append claude-sonnet-5-0 after sonnet-4-6 preserving the ${VAR:-default} override pattern and left-to-right walk; (2) ENGINE_LABEL updated to name the per-tier fallback chains; (3) aw.sh known_engines includes claude-sonnet-5-0; (4) test_engine_chain.bats extended (chain contents, rate-limit walk to sonnet-5, action-tier scope guard) and bats + shellcheck CI pass; (5) change is config/chain only — no export-list or architecture changes, gemini/copilot arms untouched; (6) sonnet-5 sits as a fallback candidate, not a replacement, matching the story's out-of-scope guidance for the action tier.
Findings
No blocking findings. Secret scan: the run_secret_scanning MCP tool is not available in this environment; the gitleaks CI check is green and the diff contains only model-id strings and test fixtures — no credential-like content. Prior Copilot review comment (ENGINE_LABEL not reflecting new chain membership) was addressed in commit 8718170 and the review thread is resolved. Informational, non-blocking: the walk only reaches claude-sonnet-5-0 when both earlier models are rate-limited, and it is last in the chain, so blast radius is minimal even if the model id is not yet live; the in-diff comment correctly notes the shared daily cap (#206) limits what this hop can help with.
CI status
All required checks green: shellcheck, bats, unit-tests, CodeQL (actions + python), gitleaks secret scan, Agent Security Scan, SonarCloud (quality gate passed, 0 new issues), agent-shield, aw compile/validate, template-drift, holdout/test-deletion guards. Dependabot and language-specific dependency-audit jobs skipped (conditional, not applicable).
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.



Closes #1098
Implemented by dev-lead agent. Please review.