Skip to content

feat: implement issue #1098 — [Phase 2] Wire claude-sonnet-5 into the Claude model chains as a candidate - #1115

Merged
don-petry merged 2 commits into
mainfrom
dev-lead/issue-1098-20260704-2108
Jul 8, 2026
Merged

don-petry merged 2 commits into
mainfrom
dev-lead/issue-1098-20260704-2108

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #1098

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings July 4, 2026 21:24
@don-petry
don-petry requested a review from a team as a code owner July 4, 2026 21:24
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 215358a9-c903-4400-85f4-6debdba96f06

📥 Commits

Reviewing files that changed from the base of the PR and between c455a1f and 8718170.

📒 Files selected for processing (3)
  • scripts/aw.sh
  • scripts/engine.sh
  • tests/dev-lead/unit/test_engine_chain.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-1098-20260704-2108

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 4, 2026 21:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds claude-sonnet-5-0 as a fallback candidate to the Claude triage and deep model chains, and registers it in the known engines list. It also includes unit tests to verify the updated chains, fallback behavior under rate-limiting, and that the action chain remains unaffected. There are no review comments, so I have no feedback to provide.

@don-petry
don-petry disabled auto-merge July 4, 2026 21:26
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: (N/A - no fixes required)
Skipped: 0
Status: Quality gate passed ✅
```

@don-petry
don-petry enabled auto-merge (squash) July 4, 2026 21:26
@don-petry
don-petry disabled auto-merge July 4, 2026 21:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Wires claude-sonnet-5-0 into the Claude in-engine fallback chains (as a non-default fallback candidate) and extends validation/tests so the harness can walk to Sonnet 5 under Claude rate-limit conditions without altering overall engine architecture.

Changes:

  • Append claude-sonnet-5-0 to CLAUDE_TRIAGE_MODEL_CHAIN and CLAUDE_DEEP_MODEL_CHAIN defaults (leaving action/audit/single unchanged).
  • Extend tests/dev-lead/unit/test_engine_chain.bats to assert the new chain contents and the rate-limit walk reaching Sonnet 5.
  • Add claude-sonnet-5-0 to scripts/aw.sh’s known_engines allowlist to keep aw compile warning-free for workflows that pin it.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
scripts/engine.sh Appends Sonnet 5 to Claude triage/deep fallback chains as a candidate.
scripts/aw.sh Adds Sonnet 5 engine id to the aw compile known-engines warning suppressor set.
tests/dev-lead/unit/test_engine_chain.bats Adds unit tests asserting the new chain membership and fallback-walk behavior.

Comment thread scripts/engine.sh
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 4, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 8718170b5624adcfb48e42f347749f04850ec21c
Review mode: triage-approved (single reviewer)

Summary

Config-only change appending claude-sonnet-5-0 as a fallback candidate after sonnet-4-6 in the Claude triage and deep model chains, updating ENGINE_LABEL, and adding the id to aw.sh known_engines. All 6 acceptance criteria of #1098 are met, the single prior review finding (stale ENGINE_LABEL) was fixed at the head commit with the thread resolved, and all CI checks are green. Confirms the triage low-risk assessment.

Linked issue analysis

Issue #1098 asks to wire claude-sonnet-5 into the Claude chains as a candidate (not fleet default). Verified against each AC: (1) triage/deep chains append claude-sonnet-5-0 after sonnet-4-6 preserving the ${VAR:-default} override pattern and left-to-right walk; (2) ENGINE_LABEL updated to name the per-tier fallback chains; (3) aw.sh known_engines includes claude-sonnet-5-0; (4) test_engine_chain.bats extended (chain contents, rate-limit walk to sonnet-5, action-tier scope guard) and bats + shellcheck CI pass; (5) change is config/chain only — no export-list or architecture changes, gemini/copilot arms untouched; (6) sonnet-5 sits as a fallback candidate, not a replacement, matching the story's out-of-scope guidance for the action tier.

Findings

No blocking findings. Secret scan: the run_secret_scanning MCP tool is not available in this environment; the gitleaks CI check is green and the diff contains only model-id strings and test fixtures — no credential-like content. Prior Copilot review comment (ENGINE_LABEL not reflecting new chain membership) was addressed in commit 8718170 and the review thread is resolved. Informational, non-blocking: the walk only reaches claude-sonnet-5-0 when both earlier models are rate-limited, and it is last in the chain, so blast radius is minimal even if the model id is not yet live; the in-diff comment correctly notes the shared daily cap (#206) limits what this hop can help with.

CI status

All required checks green: shellcheck, bats, unit-tests, CodeQL (actions + python), gitleaks secret scan, Agent Security Scan, SonarCloud (quality gate passed, 0 new issues), agent-shield, aw compile/validate, template-drift, holdout/test-deletion guards. Dependabot and language-specific dependency-audit jobs skipped (conditional, not applicable).


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 3b56047 into main Jul 8, 2026
30 checks passed
@don-petry
don-petry deleted the dev-lead/issue-1098-20260704-2108 branch July 8, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 2] Wire claude-sonnet-5 into the Claude model chains as a candidate

3 participants