P2 (#860 follow-up): keep agent branches rebased/squashed instead of merge-stacked #949

Activity

1. don-petry

   added

   enhancementFeature requestsFeature requests

   on Jun 26, 2026
2. github-actions commented on Jun 26, 2026

   

   github-actionsBot

   on Jun 26, 2026 – with GitHub Actions

   Contributor

   More actions

   Thanks for the thorough write-up and for linking this back to the #860/#926 runaway remediation — the commit-inflation root cause is clearly documented here. Before planning the implementation: the issue presents two approaches (full rebase/squash automation via the existing auto-rebase path, vs. a smell-detector lint flag), and notes the choice should be scoped during planning — do you have a preference between the two, or is the deciding factor whether the auto-rebase path can handle agent branches without touching the auto-rebase/stable pin constraint?
3. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jul 3, 2026
4. don-petry commented on Jul 3, 2026

   

   don-petry

   on Jul 3, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #949 — P2 (#860 follow-up): keep agent branches rebased/squashed instead of merge-stacked

   Scope

   Full rebase-vs-merge automation lives in the central auto-rebase reusable workflow (this repo only carries a thin caller stub pinned to auto-rebase/stable, which AGENTS.md forbids repointing), so per the acceptance-criteria fallback I implement the smell-detector path: flag PRs whose commit count vastly exceeds their changed-file count (the #860 merge-stacking signature — 378 commits for an 18-file net diff) as a rebase/squash candidate, complementing the #948 runaway detection net. No touch to the #655 guards or the auto-rebase/stable pin.

   Implementation Checklist

   • scripts/lib/pr-runaway-detect.sh — add pr_rebase_smell <commits> <changed_files> pure function + env-overridable thresholds REBASE_SMELL_MIN_COMMITS (50) / REBASE_SMELL_MAX_FILES (20); extend generate_runaway_report header to document the new criterion.
   • scripts/pr_runaway_scan.sh — extract changed_files from the PR detail, call pr_rebase_smell, and fold its reason into the existing candidate reasons (detection-only, no PR mutation).

   Tests to Write

   • tests/test_pr_runaway_detect.bats — boundary (strict >/<), the feat: implement issue #846 — [Phase 2] Cache the LSP index and enforce the 30s cold-start SLA with auto-skip #860 378/18 case fires, a normal 60-file/60-commit PR does not, 0-file glitch does not, env-override respected, defensive non-numeric input.

   Test Command

   bash scripts/run-bats.sh tests/test_pr_runaway_detect.bats and bash .dev-lead/scripts/dev-lead-lint.sh
5. don-petry commented on Jul 3, 2026

   

   don-petry

   on Jul 3, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Scope decision

   Full rebase-vs-merge main automation lives in the central auto-rebase reusable workflow — this repo carries only the thin caller stub, which AGENTS.md forbids repointing off the auto-rebase/stable channel. So per the acceptance-criteria fallback ("a clear rationale + smell-detector if full automation is out of scope") I implemented the merge-stacked smell-detector, complementing the #948 runaway net. No #655 guard or auto-rebase/stable pin was touched.

   Plan Execution

   • Added pr_rebase_smell <commits> <changed_files> pure function + env-overridable thresholds REBASE_SMELL_MIN_COMMITS (50) / REBASE_SMELL_MAX_FILES (20) to scripts/lib/pr-runaway-detect.sh
   • Extended generate_runaway_report header to document the merge-stacked criterion (P2 (#860 follow-up): runaway-PR detection in daily health check (commits/comments/cycles/age thresholds) #948 / P2 (#860 follow-up): keep agent branches rebased/squashed instead of merge-stacked #949)
   • Wired changed_files extraction + the smell into scripts/pr_runaway_scan.sh (detection-only, no PR mutation)
   • Added 9 unit tests to tests/test_pr_runaway_detect.bats (already in the lint bats list)

   Behaviour

   Flags any open PR whose commit count vastly exceeds its changed-file count — the #860 signature (378 commits for an 18-file net diff) — as a rebase/squash candidate, surfaced in the existing daily runaway report. Fires only when commits > 50 AND 0 < changed_files < 20, so a genuinely broad PR (60 commits / 60 files) does not flag, and a 0-file API glitch does not false-positive. Thresholds are independently env-overridable, so an operator can catch merge-stacking below the runaway commit floor.

   Test Results

   34 tests (tests/test_pr_runaway_detect.bats), 0 failures
   59 tests (detect + regression + budget suites), 0 failures
   shellcheck: clean (warning level) · dev-lead-lint.sh: all checks passed
   

   Files Changed

   • scripts/lib/pr-runaway-detect.sh: pr_rebase_smell fn + REBASE_SMELL_* thresholds + report-header docs
   • scripts/pr_runaway_scan.sh: extract changed_files, fold the smell into per-PR reasons, threshold log line
   • tests/test_pr_runaway_detect.bats: 9 new cases (boundary, feat: implement issue #846 — [Phase 2] Cache the LSP index and enforce the 30s cold-start SLA with auto-skip #860 case, broad-PR/0-file false-positive guards, env overrides, defensive input, report docs)

   Notes

   Detection-only, consistent with #948 — no PR is mutated, labeled, or commented. is_pr_runaway (the 4-metric boolean wrapper) is intentionally unchanged; the scan consumes the combined reasons string directly. Possible follow-up: an automated rebase-intent nudge on flagged PRs, which belongs in the central reusable workflow, not this thin-caller repo.
6. don-petry

   closed this as completedin #1053on Jul 3, 2026
7. don-petry

   added a commit that references this issue on Jul 3, 2026

   feat: implement issue #949 — P2 (#860 follow-up): keep agent branches…

   ...

   ebaf3a7