[Phase 2] Repin .github-private's feature-ideation.yml stub to the feature-ideation/next channel + update its compliance test #874

Activity

1. github-actions

   added

   initiativeEpic / initiative tracking issueEpic / initiative tracking issue

   on Jun 21, 2026
2. github-actions

   added a parent issue on Jun 21, 2026

   • Initiative: Consolidate Discussion-triggered ideation into feature-ideation, deprecate idea-enhancer, and ring-release fleet-wide #872
3. github-actions

   marked this as blocked on Jun 21, 2026

   • [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent #873
4. github-actions

   marked this as blocking on Jun 21, 2026

   • [Phase 2] Validate the folded feature-ideation enhancement mode on real .github-private Discussions (next ring) #875
5. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jun 21, 2026
6. don-petry commented on Jun 21, 2026

   

   don-petry

   on Jun 21, 2026

   Collaborator

   More actions

   Dev-Lead Implementation Plan

   Issue: #874 — [Phase 2] Repin .github-private's feature-ideation.yml stub to the feature-ideation/next channel + update its compliance test

   Scope

   Repin the feature-ideation.yml thin-caller stub from the @v1 SHA to the feature-ideation/next channel tag, document the repin as a sanctioned ring-release exception in-stub, and rewrite test_feature_ideation.bats to assert the channel pin.

   Implementation Checklist

   • .github/workflows/feature-ideation.yml — change the single uses: ref from ...feature-ideation-reusable.yml@897e4de… # v1 to ...@feature-ideation/next; nothing else in the stub changes (triggers, guard, permissions, secrets, target_discussion, project_context all stay)
   • .github/workflows/feature-ideation.yml — add a short comment recording the channel-tag pin as the sanctioned ring-release mechanism (explicit, documented override of the stub's "do not edit the uses: line" guidance), citing the ring-release model
   • tests/test_feature_ideation.bats — replace the V1_SHA / # v1 / "not pinned to v2" assertions with a channel-pin assertion (uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@feature-ideation/next); keep the "calls the org reusable" assertion

   Tests to Write

   • bats: stub pins the reusable to @feature-ideation/next (channel tag)
   • bats: keep "calls the org reusable workflow" assertion
   • bats: remove the now-wrong V1-SHA pin / # v1 annotation / v2-SHA-guard tests

   Test Command

   bats tests/test_feature_ideation.bats (full suite via scripts/run-bats.sh), plus bash .dev-lead/scripts/dev-lead-lint.sh

   Note — merge gate (untracked prerequisites, per Dev Notes / epic #872)

   This repin depends on two prerequisites that live in petry-projects/.github: (a) the feature-ideation/next channel tag existing there, and (b) the org non-stub-feature-ideation.yml audit accepting a channel-tag pin. Checked via git ls-remote: no feature-ideation/* tags currently exist on petry-projects/.github. Implementing the code change now, but this must be confirmed in place before merging or the uses: ref will not resolve / #629 re-triggers.
7. don-petry commented on Jun 21, 2026

   

   don-petry

   on Jun 21, 2026

   Collaborator

   More actions

   Dev-Lead: Implementation Complete

   Plan Execution

   • Repinned the single uses: ref in .github/workflows/feature-ideation.yml from @897e4de… # v1 to @feature-ideation/next (AC test issue from agent #1, Go-live improvements for PR review agent #2)
   • Added an in-stub comment documenting the channel-tag pin as the sanctioned ring-release exception to the stub's "do not edit the uses: line" rule, citing AGENTS.md / versioning.md and the auto-rebase @v2 precedent (AC Optimize review: small-PR and incremental fast paths #4)
   • Rewrote tests/test_feature_ideation.bats: replaced the V1_SHA pin / # v1 annotation / "not pinned to v2 SHA" assertions with a single channel-pin assertion; kept the "calls the org reusable workflow" assertion (AC Add @claude delegation, auto-merge, and rebase handling #3)

   Test Results

   $ bats tests/test_feature_ideation.bats
   1..3
   ok 1 feature-ideation.yml exists
   ok 2 feature-ideation.yml calls the org reusable workflow
   ok 3 feature-ideation.yml pins the reusable to the feature-ideation/next channel tag
   
   $ bash .dev-lead/scripts/dev-lead-lint.sh
     [lint] shellcheck on 73 file(s)...
     [lint] validating 4 agent profile(s)...
     [lint] validating .github/CODEOWNERS...
     [lint] all checks passed
   
   # regression check — related suites still green
   $ bats tests/test_consumer_manifest.bats tests/test_downstream_impact_regression.bats
   ... all ok (manifest + downstream-impact golden fixtures unaffected)
   

   TDD: the channel-pin assertion failed (red) against the old @v1 SHA pin, then passed (green) after the repin.

   Files Changed

   • .github/workflows/feature-ideation.yml: single uses: ref repinned to @feature-ideation/next + a sanctioned-ring-release comment above it. No other part of the stub changed — triggers (schedule + workflow_dispatch + discussion:created), the ideas/non-Bot guard, permissions:, secrets:, target_discussion, and project_context are all byte-identical.
   • tests/test_feature_ideation.bats: asserts the @feature-ideation/next channel pin (and the org reusable path); dropped the now-wrong SHA/# v1/v2-guard tests. YAML validated; file passes.

   Notes — MERGE GATE (untracked prerequisites, per Dev Notes / epic #872)

   This repin depends on two prerequisites that live in petry-projects/.github, not this repo:

   1. The feature-ideation/next channel tag must exist on petry-projects/.github. I checked via git ls-remote --tags https://github.com/petry-projects/.github.git — no feature-ideation/* tags currently exist there. Until that tag is cut, this stub's uses: ref will not resolve and the workflow will fail to start.
   2. The org non-stub-feature-ideation.yml compliance audit must accept a channel-tag pin (otherwise the Compliance: non-stub-feature-ideation.yml #629 finding re-triggers on this repo).

   The code change is complete and self-consistent, but both prerequisites must be confirmed in place before this is merged. I cannot create cross-repo tags or merge, so flagging here for the maintainer.
8. don-petry

   added a commit that references this issue on Jun 25, 2026

   feat: implement issue #874 — [Phase 2] Repin .github-private's featur…

   ...

   598af55
9. don-petry

   closed this as completedin #900on Jun 25, 2026