[Fleet Monitor] petry-projects/.github-private — pr-review-mention.yml #431

Activity

1. don-petry

   added

   health-checkAutomated health check reportAutomated health check report

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   fleet-trackerTracked by the Actions Fleet MonitorTracked by the Actions Fleet Monitor

   and removed

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jun 4, 2026
2. don-petry commented on Jun 8, 2026

   

   don-petry

   on Jun 8, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #431 — [Fleet Monitor] petry-projects/.github-private — pr-review-mention.yml

   Scope

   Sync the pr-review-mention.yml thin-caller stub to the org standard template by replacing the explicit secrets: block with secrets: inherit, eliminating the drift that causes ~12% of workflow runs to fail.

   Root Cause

   .github/workflows/pr-review-mention.yml passes secrets explicitly to the reusable:

   secrets:
     GH_PAT_WORKFLOWS: ${{ secrets.GH_PAT_WORKFLOWS }}
     DON_PETRY_BOT_GH_PAT: ${{ secrets.DON_PETRY_BOT_GH_PAT }}

   The org standard template (petry-projects/.github/standards/workflows/pr-review-mention.yml) uses secrets: inherit, which was the intended form when the stub was built. Explicit secret expansion causes action_required outcomes when the calling context cannot expand one or both secrets (e.g., triggered by pull_request_review_comment or pull_request events from certain actors). action_required conclusions are counted as failures by the Fleet Monitor.

   Implementation Checklist

   • tests/test_pr_review_mention_stub.py — new compliance test that asserts secrets: inherit is used (TDD: red first)
   • .github/workflows/pr-review-mention.yml — replace explicit secrets: block with secrets: inherit; also sync the Requires: comment to match the org standard

   Tests to Write

   • tests/test_pr_review_mention_stub.py — reads the local YAML, checks jobs.pr-review-mention.secrets == 'inherit', fails if explicit mapping is present

   Test Command

   python3 tests/test_pr_review_mention_stub.py
3. don-petry commented on Jun 8, 2026

   

   don-petry

   on Jun 8, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Plan Execution

   • Identified root cause: explicit secrets: block diverged from org standard (secrets: inherit)
   • Wrote failing compliance test tests/test_pr_review_mention_stub.py (TDD red)
   • Updated .github/workflows/pr-review-mention.yml to use secrets: inherit (TDD green)
   • Ran full test suite (all pass) and scripts/dev-lead-lint.sh (all pass)
   • Rubber duck review confirmed changes are minimal and correct

   Root Cause

   The local stub used an explicit secrets: block:

   secrets:
     GH_PAT_WORKFLOWS: ${{ secrets.GH_PAT_WORKFLOWS }}
     DON_PETRY_BOT_GH_PAT: ${{ secrets.DON_PETRY_BOT_GH_PAT }}

   The org standard template (petry-projects/.github/standards/workflows/pr-review-mention.yml) uses secrets: inherit. Explicit secret expansion triggers action_required outcomes when the calling context cannot expand one or both secrets (e.g., for pull_request_review_comment or review_requested events from certain actors). action_required runs are counted as failures by the Fleet Monitor.

   Test Results

   # Compliance test (new)
   python3 tests/test_pr_review_mention_stub.py
   OK: uses = 'petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@v2'
   OK: secrets: inherit
   PASS: .github/workflows/pr-review-mention.yml conforms to the org standard stub contract.
   
   # Unit tests
   bash tests/test_copilot_chat.sh     → Results: 13 passed, 0 failed
   bash tests/test_list_prs_sort.sh    → Results: 17 passed, 0 failed
   
   # Bats suite (fleet_report, token_report, model_pricing, test_review_cycle)
   1..93  (93 tests, 0 failures)
   
   # dev-lead-lint.sh
   shellcheck on 34 file(s)... PASS
   validating 4 agent profile(s)... PASS
   [lint] all checks passed
   

   Files Changed

   • .github/workflows/pr-review-mention.yml: replaced explicit secrets: block with secrets: inherit; synced Requires: comment to match org standard
   • tests/test_pr_review_mention_stub.py: new compliance test — validates the stub uses secrets: inherit

   Notes

   Triggers and job-level permissions were not changed (per the stub's AGENTS contract). The reusable itself (pr-review-mention-reusable.yml@v2) already handles empty/inherited secrets gracefully via its job-level if: condition.
4. don-petry

   added 4 commits that reference this issue on Jun 14, 2026

   feat: implement issue #431 — [Fleet Monitor] petry-projects/.github-p…

   ...

   a60f9e4

   feat: implement issue #431 — [Fleet Monitor] petry-projects/.github-p…

   ...

   f719149

   feat: implement issue #431 — [Fleet Monitor] petry-projects/.github-p…

   ...

   e55cec7

   feat: implement issue #431 — [Fleet Monitor] petry-projects/.github-p…

   ...

   52fbb2b
5. don-petry commented on Jul 15, 2026

   

   don-petry

   on Jul 15, 2026

   CollaboratorAuthor

   More actions

   ✅ Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-06-04 (41 days) — the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.
6. don-petry

   closed this as completedon Jul 15, 2026