Skip to content

[Fleet Monitor] petry-projects/.github-private β€” dev-lead.ymlΒ #341

Closed

Description

@don-petry

🟑 WARNING: petry-projects/.github-private / dev-lead.yml

Metric Value
Failure Rate 14.5% (39 / 269 runs)
Status WARNING
p50 Duration 2s
p95 Duration 358s
Successful Runs 24
Cancelled Runs 137

Workflow: dev-lead.yml

Last updated by Fleet Monitor run on 2026-06-04.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    health-checkAutomated health check report
    dev-leadFor dev-lead agent pickup
    fleet-trackerTracked by the Actions Fleet Monitor
    on May 21, 2026
  2. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 8, 2026
  3. don-petry commented on Jun 9, 2026

    @don-petry
    CollaboratorAuthor
    All engines are currently rate-limited. Please re-apply the `dev-lead` label when the rate limit clears to retry.
  4. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 9, 2026
  5. don-petry commented on Jun 9, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #341 β€” [Fleet Monitor] petry-projects/.github-private β€” dev-lead.yml

    Scope

    Fix the two runtime failure modes causing the 14.5% failure rate in dev-lead.yml: (1) checkout_pr_in_worktree crashing when a PR is merged and its branch deleted before checkout, and (2) push_with_merge_guard failing the workflow when a push is rejected due to concurrent runs.

    Root Cause Analysis

    From workflow run logs, two distinct runtime failures are responsible for the failure rate:

    1. Closed/merged PR checkout failure (scripts/lib/pr-worktree.sh)

    2. Concurrent push rejection (scripts/lib/auto-merge.sh)

    Implementation Checklist

    • scripts/lib/pr-worktree.sh: in checkout_pr_in_worktree, catch gh pr checkout failures and check PR state β€” exit 0 cleanly if PR is closed/merged
    • scripts/lib/auto-merge.sh: in push_with_merge_guard, detect "fetch first" rejection and attempt git pull --rebase + retry; if retry fails, exit 0 (concurrent run handled it)

    Tests to Write

    • tests/dev-lead/unit/test_pr_worktree.bats: new test β€” checkout exits 0 when gh pr checkout fails and PR is closed/merged
    • tests/dev-lead/unit/test_auto_merge.bats: new test β€” push_with_merge_guard retries with pull-rebase on fetch-first rejection and succeeds
    • tests/dev-lead/unit/test_auto_merge.bats: new test β€” push_with_merge_guard exits 0 cleanly when rebase/retry also fails (concurrent run scenario)

    Test Command

    bash scripts/dev-lead-lint.sh
    (Full bats tests require sudo apt-get install bats which isn't available locally; the CI bats suite at .github/workflows/ci.yml covers the unit tests.)

  6. don-petry commented on Jul 15, 2026

    @don-petry
    CollaboratorAuthor

    βœ… Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-06-04 (41 days) β€” the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupfleet-trackerTracked by the Actions Fleet Monitorhealth-checkAutomated health check report

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions