Skip to content

PR Review Agent: run #715 aborted early — 3 failure modes identified #145

Closed
3 of 3 issues completed
Closed

Description

@don-petry

Summary

Run #715 of the PR Review Agent (scheduled, 2026-05-12) processed only 2 of 20 candidates before aborting early. Three distinct failure modes cascaded to cause the abort.

Failure sequence

  1. Claude opus-4-7 hit a rate limit during the approval-confirmation step for ContentTwin/pull/72.
  2. Gemini fallback was unavailable — CLI not installed / no GOOGLE_API_KEY — so the session fell through to the Copilot engine.
  3. Copilot CLI triage command was rejected with error: Invalid command format. The rate-limit detector misclassified this as a rate-limit hit (exit 2), leaving no fallback and aborting the session with 18 PRs unprocessed.

Sub-issues

Impact

18 PR candidates skipped in a single run; any run where Claude is rate-limited on the approval path is now fully unprotected.

Activity

  1. don-petry commented on Jul 14, 2026

    @don-petry
    CollaboratorAuthor

    Closing as resolved — this umbrella post-mortem's three sub-issues are all fixed:

    The three cascading failure modes are gone: the engine cascade (Claude→Gemini→Copilot) now discriminates exit codes correctly (is_rate_limited() in engine.sh narrowed; runtime-unavailable is exit 55, rate-limit exit 2), covered by test_batch_fallback.bats / test_batch_skip_reporting.bats. A single PR's engine failure no longer aborts the whole batch (the '18 PRs unprocessed' impact). The incident referenced opus-4-7 (now 4-8) and predates the substantial pr-review rework since (advisory gate #457, sweep #573/#898, timeout #901). Nothing left to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBug reports

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions