[#1052 C+E] dev-lead prompt guardrail (no undeclared channel-stub input forward) + codify in AGENTS.md & org ci-standards #1254

Activity

1. don-petry

   added

   enhancementFeature requestsFeature requests

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jul 15, 2026
2. don-petry

   added a parent issue on Jul 15, 2026

   • fix(ci): prevent channel-skew workflow breakage — guard forwarded inputs vs pinned refs + codify the pinning rules (post-#1034) #1052
3. don-petry commented on Jul 15, 2026

   

   don-petry

   on Jul 15, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #1254 — [#1052 C+E] dev-lead prompt guardrail (no undeclared channel-stub input forward) + codify in AGENTS.md & org ci-standards

   Scope

   Add a dev-lead prompt guardrail forbidding the agent from adding/modifying a with: forward on a channel-pinned caller stub to pass an input the pinned channel does not yet declare (with the correct land→promote→forward sequencing), and codify the rule in AGENTS.md + org ci-standards.

   Implementation Checklist (Part C)

   • tests/dev-lead/unit/test_channel_stub_forward_guardrail.bats — new bats guard (written first, red)
   • prompts/dev-lead/fix-reviews.md — add guardrail blockquote
   • prompts/dev-lead/review-changes.md — add guardrail blockquote
   • prompts/dev-lead/fix-bot-comment.md — add guardrail blockquote
   • prompts/dev-lead/on-mention.md — add guardrail blockquote
   • prompts/dev-lead/fix-issue.md — add guardrail blockquote (implementation prompt)
   • prompts/dev-lead/fix-ci.md — add guardrail blockquote (implementation/remediation prompt)

   Implementation Checklist (Part E)

   • AGENTS.md — new subsection "Caller-stub input forwarding across channel pins" under "Release channel tags & the mutable-ref exception"; cross-reference from the "Workflow Files" thin-caller-stub bullets and the Part A guard ([#1052 A] CI guard: forwarded caller inputs ⊆ declared inputs at the pinned @ref (+ #1034 regression) #1253)
   • Org-wide petry-projects/.github/standards/ci-standards.md — editing that repo is out of this task's write scope, so open a linked companion issue against petry-projects/.github (do not silently drop)

   Tests to Write

   • Guardrail text present in every relevant prompt
   • Guardrail names the land→promote→forward sequencing and cut-release.sh --channel
   • Guardrail cites the AGENTS.md mutable-ref exception section

   Test Command

   bats tests/dev-lead/unit/ (also bash .dev-lead/scripts/dev-lead-lint.sh + shellcheck scripts/*.sh)
4. don-petry commented on Jul 15, 2026

   

   don-petry

   on Jul 15, 2026

   CollaboratorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Plan Execution

   • Part C — new bats guard tests/dev-lead/unit/test_channel_stub_forward_guardrail.bats (written red-first)
   • Part C — guardrail + land→promote→forward sequencing added to the feedback/implementation prompts
   • Part E — AGENTS.md: new subsection "Caller-stub input forwarding across channel pins" + cross-refs from the thin-caller-stub bullets
   • Part E — org standard: linked companion issue opened (editing petry-projects/.github is outside this run's write scope)

   New guard test output

   1..3
   ok 1 channel-stub-forward guardrail: present in every relevant prompt (#1254)
   ok 2 channel-stub-forward guardrail: names the land -> promote -> forward sequencing (#1254)
   ok 3 channel-stub-forward guardrail: cross-references the AGENTS.md subsection (#1254)
   

   Verification

   • bats tests/dev-lead/unit/ — 642 pass. One unrelated failure (test_engine_mcp.bats:360, an MCP debug-handshake test) reproduces on a clean tree with all my changes stashed → pre-existing/environmental, not a regression from this markdown-only change.
   • bash .dev-lead/scripts/dev-lead-lint.sh — all checks passed (shellcheck on 86 files + 4 agent profiles + CODEOWNERS).
   • tests/dev-lead/integration/test_prompt_coverage.sh — PASS (all prompt variable declarations valid).

   Files Changed

   • tests/dev-lead/unit/test_channel_stub_forward_guardrail.bats (new): asserts the guardrail text, the cut-release.sh --channel sequencing, and the AGENTS.md subsection cross-ref are present in all 6 relevant prompts.
   • prompts/dev-lead/{fix-issue,fix-ci,fix-reviews,review-changes,fix-bot-comment,on-mention}.md: added the "never forward an undeclared input across a channel pin" guardrail + 3-step sequencing.
   • AGENTS.md: new subsection under "Release channel tags & the mutable-ref exception" (rule + sequencing + Part A guard [#1052 A] CI guard: forwarded caller inputs ⊆ declared inputs at the pinned @ref (+ #1034 regression) #1253 cross-ref + promotion pointer); cross-referenced from the dev-lead.yml and auto-rebase.yml thin-caller-stub bullets.

   Org-standard companion (Part E)

   Editing petry-projects/.github/standards/ci-standards.md is outside this dev-lead run's write scope (only this repo's branch is committed by CI), so the org-wide rule is tracked in a linked companion issue — not silently dropped:

   • Codify org-wide: caller-stub input forwarding across channel pins (channel-skew prevention) .github#736 — "Codify org-wide: caller-stub input forwarding across channel pins"

   Notes

   • Prompt scope: the 4 existing channel-ref feedback prompts + the two implementation prompts (fix-issue.md, fix-ci.md), since a with: forward can be introduced while implementing an issue or "fixing" the very CI failure the skew causes.
   • Independent of Part A ([#1052 A] CI guard: forwarded caller inputs ⊆ declared inputs at the pinned @ref (+ #1034 regression) #1253) — no lint.yml/script overlap — so it can land in parallel.
5. don-petry

   added a commit that references this issue on Jul 15, 2026

   feat: implement issue #1254 — [#1052 C+E] dev-lead prompt guardrail (…

   ...

   7b1d1b0
6. don-petry

   closed this as completedin #1258on Jul 15, 2026