Reconnect tracker after turn off and on#318
Open
throni3git wants to merge 3 commits into
Open
Conversation
added 3 commits
October 21, 2024 13:26
…ive_device_is_rf is true for the object
…er tracker was turned off and on again
bl4ckb0ne
requested changes
Jul 13, 2026
Comment on lines
+475
to
+486
| static bool survive_device_is_rf(const struct DeviceInfo *device_info) { | ||
| switch (device_info->type) { | ||
| case USB_DEV_HMD: | ||
| case USB_DEV_HMD_IMU_LH: | ||
| case USB_DEV_W_WATCHMAN1: | ||
| case USB_DEV_TRACKER0: | ||
| case USB_DEV_TRACKER1: | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
The function needs a better place, I'm not fond of moving it higher so src/driver_vive_libusb.h can use it.
Author
There was a problem hiding this comment.
what would be a better solution?
Collaborator
There was a problem hiding this comment.
Have the signature moved to src/driver_vive.libusb.h, somewhere in the beginning of the file.
Collaborator
|
Apologies for the delay in the review, I wrote the comment and forgot to submit it, it has been pending for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When turning a watchman-connected tracker device off and on again, the global scene solver failed due to some old scenes and the
handle_transferfunction insrc/driver_vive.libusb.hdid not go to theobject_turned_offlabel. More info in #314.