Skip to content

9306 pty #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
destitutus merged 45 commits into from
Jun 21, 2018
Merged

9306 pty #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
1bc941a
add support for .on('exit', function (code, signal) {})
joshwilsdon Feb 21, 2015
568d186
use an arg instead of arguments[0]
joshwilsdon Feb 22, 2015
aa2fbee
htop command cannot resize with env.LINSE and env.COLUMNS
vangie Apr 6, 2015
dbfb57a
v0.2.8. fixes #122.
chjj Jul 5, 2015
b15642e
Merge pull request #110 from joshwilsdon/exitStatus
chjj Jul 30, 2015
d497a37
style conventions.
chjj Jul 30, 2015
647bcae
fix build. see #110.
chjj Jul 30, 2015
b4e213f
call uv_close to take cb off the event loop. see #110.
chjj Jul 30, 2015
8d1b6b8
more style fixes.
chjj Jul 30, 2015
efa3bea
use older v8 api for function casts?
chjj Jul 30, 2015
b242815
fix after_wait_on_pid for node v0.10.x. see #110.
chjj Jul 31, 2015
c1ffc0e
fix close events. see #110.
chjj Jul 31, 2015
457a970
v0.2.9
chjj Jul 31, 2015
3e6b21d
refactor waitpid thread.
chjj Aug 1, 2015
feac246
refactor pty.fork args.
chjj Aug 1, 2015
a92a38e
free up baton in uv_close callback. see #110.
chjj Aug 1, 2015
4af6285
fix issue where exit is emitted before the last data event. see #110.
chjj Aug 1, 2015
5746a30
account for node v0.8.x on waitpid. see #110.
chjj Aug 2, 2015
58378aa
v0.2.10
chjj Aug 2, 2015
b587bc6
Merge pull request #117 from vangie/fix_htop_incorrect_resize
chjj Aug 2, 2015
87c3584
add comment.
chjj Aug 2, 2015
b8c5fa2
v0.2.11
chjj Aug 2, 2015
b4d9445
better onexit callback.
chjj Aug 2, 2015
d2fcdb6
event better onexit callback. see #110.
chjj Aug 4, 2015
cd58363
v0.2.12
chjj Aug 4, 2015
e477660
create scope in pty_after_waitpid to prevent fatal v8 error in io.js.…
chjj Aug 5, 2015
a2c2f7a
v0.2.13
chjj Aug 5, 2015
91fb97f
upgrade to nan 2.0.5. see #127.
chjj Aug 24, 2015
1dae5e3
remove "heap-style" Nan::Callback.
chjj Aug 24, 2015
311ca65
strict nan version.
chjj Aug 24, 2015
79d8b93
remove useless v8 namespace prefixes.
chjj Aug 24, 2015
847f650
minor: whitespace. cols.
chjj Aug 24, 2015
61cea83
bind to close only once.
chjj Aug 24, 2015
70f0799
v0.3.0
chjj Aug 24, 2015
c3499f0
update win/pty.cc to work with nan 2.0.5
nightwing Mar 8, 2015
7700f31
Merge pull request #128 from cloud9ide/nan-2
chjj Sep 10, 2015
ef6aa14
Optional resuming of the socket
apoco Jan 18, 2016
7d05463
Merge pull request #145 from apoco/paused-socket
chjj Jan 18, 2016
21270a6
update dependency nan@2.0.5 to nan@2.3.3
May 10, 2016
49f06a0
update nan to @2.3.5
Jun 6, 2016
8dcf326
Merge pull request #159 from y13i/update_nan
chjj Jul 7, 2016
fe63a41
v0.3.1
chjj Jul 7, 2016
c04e366
Merge commit 'fe63a412574f45ee6bb6d8fab4a5c102107b5201' into 9306_pty
destitutus Mar 27, 2018
34af90d
pty.kill is not a function
destitutus Mar 27, 2018
db4c254
add comment
destitutus Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/pty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,8 @@ Terminal.prototype.destroy = function() {
Terminal.prototype.kill = function(sig) {
try {
process.kill(this.pid, sig || 'SIGHUP');
pty.kill(this.pid);
} catch(e) {
console.error(e);
// Ignore if process cannot be found (kill ESRCH error)
}
};

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "pty.js",
"description": "Pseudo terminals for node.",
"author": "Christopher Jeffrey",
"version": "0.3.0",
"version": "0.3.1",
"license": "MIT",
"main": "./index.js",
"repository": "git://github.com/chjj/pty.js.git",
Expand All @@ -25,7 +25,7 @@
],
"dependencies": {
"extend": "~1.2.1",
"nan": "2.2.0"
"nan": "2.3.5"
},
"devDependencies": {
"mocha": "~1.17.1"
Expand Down