Conversation
0e2be47 to
4c9895f
Compare
4c9895f to
4d6bfc5
Compare
gsomix
reviewed
Aug 22, 2022
| } | ||
|
|
||
| let rec processLoop(processor: MailboxProcessor<_ * AsyncReplyChannel<_>>) = async { | ||
| while true do |
Member
Author
There was a problem hiding this comment.
We have several places with while true in async code already, and they seem non-problematic for now. I think I'll leave that as-is, but will keep an eye on it.
27d0db9 to
3977248
Compare
6952a9f to
2a3c54d
Compare
2a3c54d to
f6bcfff
Compare
f6bcfff to
2861ee8
Compare
1735749 to
7936682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102. I've decided we need no statistics aside from logs.
TODO:
FileCacheContentControllerTODOremaining