Merged
Conversation
Closed
jjnp
approved these changes
Jun 2, 2024
Contributor
jjnp
left a comment
jjnp
left a comment
There was a problem hiding this comment.
Fine with me. We might down the line end up changing some stuff, but I don't see why we'd start predicting the future with the PR^^ Let's merge!
jjnp
requested changes
Jun 2, 2024
Contributor
jjnp
left a comment
jjnp
left a comment
There was a problem hiding this comment.
Gibt ein paar kleinere Issues, review folgt.
Member
Author
sjaghori
previously approved these changes
Jun 3, 2024
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
mledl
approved these changes
Jun 6, 2024
Contributor
mledl
left a comment
mledl
left a comment
There was a problem hiding this comment.
Most things have been said. A really solid starting point 🚀
Let's go with this, since things will change along the way anyways.
Member
Author
|
@mledl and I agreed to move the theme discussion into another PR. @sajaghori @jjnp any open issues that still need some work? |
jjnp
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sidebar for the authenticated section of the site.
Also added the following blank pages, which can be navigated to via the sidebar
Depends on #74