Skip to content

detail roadmap#83

Open
josurodriguez wants to merge 6 commits into
masterfrom
feature/74-roadmap-detail
Open

detail roadmap#83
josurodriguez wants to merge 6 commits into
masterfrom
feature/74-roadmap-detail

Conversation

@josurodriguez
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/coderhood/coderhood/8u3199ia8
✅ Preview: https://coderhood-git-feature-74-roadmap-detail.coderhood.vercel.app

@josurodriguez josurodriguez linked an issue Oct 5, 2020 that may be closed by this pull request
@josurodriguez josurodriguez self-assigned this Oct 5, 2020
@emalorenzo
Copy link
Copy Markdown
Collaborator

emalorenzo commented Oct 5, 2020

Comment thread api/roadmaps/index.ts

export const getRoadmaps = () => {
return fetch<GetRoadmapsResponse>(
`${process.env.NEXT_PUBLIC_BASE_URL}/roadmaps`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

para que sacaste estas /? el build esta fallando por esto 🤔

Comment thread components/CardTech.tsx
Comment thread components/CardTech.tsx Outdated
Heading,
} from '@chakra-ui/core';

const CardTech = ({ image, title, description }) => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podes agregarle un interface con el tipado de esto?

Comment thread components/CardTech.tsx Outdated
<Flex flexDirection="column">
<Text
color={colorMode === 'light' ? 'gray.800' : 'gray.300'}
fontFamily="DM Sans"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que cambiamos DM Sans por Poppins puede ser? preguntale a @SantyLorenzo sobre si seguir usando DM Sans por las dudas

Comment thread components/button/Button.tsx Outdated
fontWeight: 'bold',
textTransform: 'uppercase',
},
// Two sizes: sm and md
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estos comentarios no son necesarios, el codigo es autoexplicativo en los nombres baseStyle, sizes y variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 - Roadmap detail UI

2 participants