Skip to content

fix: upgrade go-sdk to v1.4.1 and Go to 1.25 - #19

Merged
fbm3307 merged 2 commits into
codeready-toolchain:masterfrom
fbm3307:chore/upgrade-go-sdk-v1.4.1
Jul 16, 2026
Merged

fix: upgrade go-sdk to v1.4.1 and Go to 1.25#19
fbm3307 merged 2 commits into
codeready-toolchain:masterfrom
fbm3307:chore/upgrade-go-sdk-v1.4.1

Conversation

@fbm3307

@fbm3307 fbm3307 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator
  • Upgrade github.com/modelcontextprotocol/go-sdk from v1.4.0 → v1.4.1 to address GO-2026-4770 (null Unicode JSON parsing) and GO-2026-4773 (cross-site tool execution)
  • Bump Go to 1.25.8 (required by go-sdk v1.4.1+) and update CI / agent Containerfile accordingly

Follow-up to #18 (comment)

Summary by CodeRabbit

  • Chores
    • Updated the project and container build environments to Go 1.25.
    • Updated the Model Context Protocol SDK and encoding library dependencies.
    • Improved build consistency across continuous integration and containerized environments.

- Address GO-2026-4770 and GO-2026-4773 in modelcontextprotocol/go-sdk
- Align go.mod, CI, and Containerfile with mcp-server-devsandbox and tarsy

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d44647af-d7ab-4536-b8d3-7e59a2ea3c68

📥 Commits

Reviewing files that changed from the base of the PR and between 6aacce8 and bb75b8b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • Containerfile.agent
  • go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • codeready-toolchain/mcp-common (manual)
  • codeready-toolchain/mcp-server-devsandbox (manual)
  • codeready-toolchain/api (manual)
  • codeready-toolchain/toolchain-common (manual)
  • codeready-toolchain/host-operator (manual)
  • codeready-toolchain/toolchain-e2e (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: build-test-coverage
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • Containerfile.agent
  • go.mod
🔇 Additional comments (3)
go.mod (1)

3-7: LGTM!

Also applies to: 34-34

.github/workflows/ci.yml (1)

20-20: LGTM!

Containerfile.agent (1)

1-1: LGTM!


Walkthrough

The PR updates CI and container builds to Go 1.25, changes the module Go version, removes the explicit toolchain directive, and bumps the MCP SDK and encoding dependencies.

Changes

Go toolchain and dependency alignment

Layer / File(s) Summary
Toolchain and module alignment
.github/workflows/ci.yml, Containerfile.agent, go.mod
CI and container builds use Go 1.25; go.mod targets Go 1.25.8 without the explicit toolchain directive and updates the MCP SDK and encoding dependencies.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: dependencies, ci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: upgrading go-sdk and Go version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

- Clear govulncheck failures for crypto/tls, net/http, mime, and related stdlib issues fixed between 1.25.9 and 1.25.12

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
fbm3307 merged commit c2f9e32 into codeready-toolchain:master Jul 16, 2026
4 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant