Huawei HMS- Remove 'Require GMS' dialog for HMS phone user#56
Open
minUswachoke wants to merge 1 commit intocodeforpublic:align-masterfrom
Open
Huawei HMS- Remove 'Require GMS' dialog for HMS phone user#56minUswachoke wants to merge 1 commit intocodeforpublic:align-masterfrom
minUswachoke wants to merge 1 commit intocodeforpublic:align-masterfrom
Conversation
… stage. Not in the mainpage, since that have to fix the location issue and might effect alot of code. What I did 1. Add Native module to check for HMS and GMS phone 2. The dialog come from the method backgroundTracking.start() 3. I cover the method checking if the phone is IOS or having GMS in the android phone to use the method 4. Requesting background location somehow didnt work in request method, this also doesnt work in normal build. But 'backgroundTracking.start() is requesting it. 5. HMS phone will not be requesting for location
Contributor
|
I think There is another indirect reference to BTW, what do you think about react-native-device-info's |
Collaborator
|
Would be great If we can achieve the same result by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version only remove the dialog "GMS unavailable" from onboarding stage. Not in the mainpage, since that have to fix the location issue and might effect alot of code. What I did