fixed: typo in example of "retryTo" in lib/effects.js#5203
fixed: typo in example of "retryTo" in lib/effects.js#5203kobenguyent merged 1 commit intocodeceptjs:3.xfrom
Conversation
|
@danielrentz may you please run this to make sure the docs are updated as well?
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the JSDoc example documentation for the retryTo function in lib/effects.js. The example was incorrectly importing hopeThat instead of retryTo.
- Corrected the import statement in the
@exampledocumentation to properly referenceretryTo
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@kobenguyent Documentation> npm install
...
> npm run docs
...
./codeceptjs/runok.js:339
for (const method of webdriverDoc[0].members.instance) {
^
TypeError: Cannot read properties of undefined (reading 'members')
at Object.docsAppium (./codeceptjs/runok.js:339:42)
at async Object.docsHelpers (./codeceptjs/runok.js:245:9)
at async Promise.all (index 0)
at async Object.docs (./codeceptjs/runok.js:29:5)leaves a locally modified Typings> npm run defdoes not modify anything. Now, running "docs" again will succeed. > npm run docs
...
> git statusleaves a locally modified Btw, the exception in the initial "docs" script seems to happen only in a freshly cloned repository, later runs will succeed, even after resetting all changed files. Testing> mocha test/unit
bash: mocha: command not foundSeems the CONTRIBUTING.md file needs some updates. The PR checklist suggests > npm testgives weird console outputs such as [object Object]] [140] Starting recording promisesand failing tests such as 1) MochawesomeHelper with retries
"before each" hook for "should add context to the correct test object when test is retried":
Error: Cannot find module 'mochawesome/addContext'
Require stack:
- ./codeceptjs/lib/helper/Mochawesome.jsConclusionThe initial change in this PR does not lead to any documentation updates. Seems the documentation for the effects functions ( Do you want me to commit the updated |
@danielrentz thanks! then all good. |
Motivation/Description of the PR
@exampledocumentation of effects/retryToApplicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)