Skip to content

refactor(plugin-js-packages): use build-md to format issue messages#772

Merged
matejchalk merged 3 commits intomainfrom
js-packages-build-md
Jul 31, 2024
Merged

refactor(plugin-js-packages): use build-md to format issue messages#772
matejchalk merged 3 commits intomainfrom
js-packages-build-md

Conversation

@matejchalk
Copy link
Collaborator

Follow-up from #755.

@matejchalk matejchalk added 🧹 maintenance 🧩 js-packages-plugin Plugin for audit and outdated dependencies labels Jul 27, 2024
@matejchalk matejchalk self-assigned this Jul 27, 2024
@matejchalk matejchalk removed the 🔬 testing writing tests label Jul 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 1e3da59 with source commit 4df1fc2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 56 🔴 43 ↓ −13
Code coverage 🟡 90 🟡 90 ↓ +0
Custom checks 🟡 67 🟡 67
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99

🗃️ Groups

👎 2 groups regressed
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 56 🔴 43 ↓ −13
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ +0

18 other groups are unchanged.

🛡️ Audits

👍 1 audit improved, 👎 6 audits regressed, 14 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 2.8 s 🟥 4.0 s ↑ +43 %
Lighthouse Speed Index 🟥 5.9 s 🟥 8.0 s ↑ +36 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟥 3.3 s ↑ +24 %
Lighthouse First Meaningful Paint 🟨 2.7 s 🟨 3.3 s ↑ +24 %
Lighthouse Time to Interactive 🟥 16.7 s 🟥 17.0 s ↑ +2 %
Code coverage Function coverage 🟩 92.2 % 🟩 92.1 % ↓ +0 %
Code coverage Branch coverage 🟨 83.9 % 🟨 83.9 % ↑ +0 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,784 KiB 🟩 Total size was 1,790 KiB ↑ +0 %
Lighthouse Minimizes main-thread work 🟥 20.4 s 🟥 24.3 s ↑ +19 %
Lighthouse Total Blocking Time 🟥 7,420 ms 🟥 8,840 ms ↑ +19 %
Lighthouse JavaScript execution time 🟥 9.8 s 🟥 10.7 s ↑ +9 %
Lighthouse Max Potential First Input Delay 🟥 2,810 ms 🟥 3,600 ms ↑ +28 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 740 ms 🟥 Potential savings of 1,430 ms ↑ +95 %
Lighthouse Metrics 🟩 16721 🟩 16999 ↑ +2 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ +0 %
Lighthouse Initial server response time was short 🟩 Root document took 430 ms 🟩 Root document took 360 ms ↓ −16 %
Lighthouse Server Backend Latencies 🟩 130 ms 🟩 80 ms ↓ −38 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −8 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 10 ms ↓ −69 %
JS Packages Outdated NPM dev dependencies. 🟨 54 outdated package versions (29 major, 19 minor, 5 patch, 1 prerelease) 🟨 55 outdated package versions (29 major, 20 minor, 5 patch, 1 prerelease) ↑ +2 %
Code coverage Line coverage 🟩 91.2 % 🟩 91.2 % ↓ +0 %

488 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review July 27, 2024 09:31
@matejchalk matejchalk requested review from BioPhoton and Tlacenka July 27, 2024 09:31
BioPhoton
BioPhoton previously approved these changes Jul 27, 2024
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reduction of the code and also better formatted! 👍

We could move the issue parsing into a separate helper. (Just a suggestion, no requirement)

Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more readable, thank you 🙏

I found one grammatical issue, see below.

@matejchalk matejchalk merged commit 2dcce47 into main Jul 31, 2024
@matejchalk matejchalk deleted the js-packages-build-md branch July 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants