refactor(plugin-js-packages): use build-md to format issue messages#772
Merged
matejchalk merged 3 commits intomainfrom Jul 31, 2024
Merged
refactor(plugin-js-packages): use build-md to format issue messages#772matejchalk merged 3 commits intomainfrom
matejchalk merged 3 commits intomainfrom
Conversation
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 1e3da59 with source commit 4df1fc2. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories🗃️ Groups👎 2 groups regressed
18 other groups are unchanged. 🛡️ Audits👍 1 audit improved, 👎 6 audits regressed, 14 audits changed without impacting score
488 other audits are unchanged. |
BioPhoton
previously approved these changes
Jul 27, 2024
Collaborator
BioPhoton
left a comment
There was a problem hiding this comment.
Nice reduction of the code and also better formatted! 👍
We could move the issue parsing into a separate helper. (Just a suggestion, no requirement)
Tlacenka
reviewed
Jul 29, 2024
Collaborator
Tlacenka
left a comment
There was a problem hiding this comment.
Much more readable, thank you 🙏
I found one grammatical issue, see below.
vmasek
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #755.