refactor(utils): use cliui as central logger#487
Merged
Conversation
06ef194 to
a13b9cd
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fba81fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
Tlacenka
reviewed
Mar 12, 2024
packages/cli/src/lib/implementation/only-plugins.utils.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/lib/implementation/execute-plugin.unit-test.ts
Outdated
Show resolved
Hide resolved
…st.ts Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
Tlacenka
previously approved these changes
Mar 12, 2024
Collaborator
Tlacenka
left a comment
There was a problem hiding this comment.
Almost there!
Once the proper matchers are applied in all applicable places, this PR is good to go from my side!
packages/cli/src/lib/print-config/print-config-command.unit.test.ts
Outdated
Show resolved
Hide resolved
matejchalk
previously approved these changes
Mar 12, 2024
…ble-from-cliui # Conflicts: # packages/utils/src/lib/git.integration.test.ts
matejchalk
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
opened Feature: Add list to the ui features poppinss/cliui#14 to get rid of 3table and use
cliuihelpers insteadopened replace issaac/cliui div with cliui helpers #513
issue opened Add flush method to empty the
logsarray in logger poppinss/cliui#15PR opened feat(logger): add flushLogs method to tests poppinss/cliui#16
Note
I will move #513 into a new PR and implement in when the PR in cliui is in if I reopen ever.
created #552
Testing:
I tried to use hooks for the logger tests to switch to
rawmode and cleanup the logsbeforeEachrun.I was only able to use this setup in
utilswhich imports directly the file:Working code:
However in
coreandclii was only able to have the mode switching in the setup script and hat to move the logger cleanup in the test files. If I importuifrom@code-pushup/utilsmany other tests fail.Working reduced script:
Update:
I was able to implement the beforeEach hook with async imports:
closes #502
related #513