AWS: do not depend on ordering of UNION ALL#1240
Closed
pobrn wants to merge 1 commit intocms-dev:masterfrom
Closed
AWS: do not depend on ordering of UNION ALL#1240pobrn wants to merge 1 commit intocms-dev:masterfrom
UNION ALL#1240pobrn wants to merge 1 commit intocms-dev:masterfrom
Conversation
Contributor
Author
|
EDIT: done, tested a bit. |
pobrn
force-pushed
the
aws_no_depend_union_all
branch
from
20211d9 to
ed9c468
Compare
Apparently neither postgres nor the SQL standard guarantees that the order of the results will match the order the of the queries[0]. If the results are not returned in order, then AWS will confuse which result belongs to which query, producing incomprehensible results on the admin page. [0]: https://dba.stackexchange.com/questions/316818/are-results-from-union-all-clauses-always-appended-in-order
pobrn
force-pushed
the
aws_no_depend_union_all
branch
from
ed9c468 to
95948a2
Compare
Member
Contributor
Author
|
You're right. The linked PR seems to fix the same issue. In any case, it would good to merge either one because this came up during IOI2023 so a fix would be appreciated. Please do note that the linked PR uses |
Contributor
Author
|
Gentle ping. Would it be possible to merge either of the PRs? |
Member
|
Thank you for the ping. Merged #1201 with a small change (to replace the deprecated add_column) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently neither postgres nor the SQL standard guarantees that the order of the results will match the order the of the queries0.
If the results are not returned in order, then AWS will confuse which result belongs to which query, producing incomprehensible results on the admin page.