Don't open title page input file in binary mode in PrintingService #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing because Jinja2 templates render to strings (unlike the previously used Tornado templates, which render to bytes)
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=======================================
Coverage 61.99% 61.99%
=======================================
Files 230 230
Lines 16604 16604
=======================================
Hits 10294 10294
Misses 6310 6310
Continue to review full report at Codecov.
|
Member
|
Thanks, the description and the fix are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrintingServicecurrently doesn't work. When someone uses it to print something, the compilation of (or rather the rendering of the template of) the title page will fail. As far as I can tell, the reason for this comes from the transition from Tornado to Jinja2:Jinja2 templates render to strings (unlike the previously used Tornado templates, which render to bytes). So we shouldn't open the output file in binary mode.
This change is