Skip to content

Remove MessageLogger summary from the comparison#2

Merged
cmsbuild merged 1 commit intocms-data:masterfrom
fabiocos:fc-mtdUnitTest
May 29, 2020
Merged

Remove MessageLogger summary from the comparison#2
cmsbuild merged 1 commit intocms-data:masterfrom
fabiocos:fc-mtdUnitTest

Conversation

@fabiocos
Copy link
Contributor

To simplify comparisons, the final MessageLogger summary is removed, differences must be zero at this point

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-sw/cmssw#29841

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29841
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6639/console Started: 2020/05/28 11:15

@cmsbuild
Copy link
Contributor

+1
Tested at: c86b2c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a73f7b/6639/summary.html
CMSSW: CMSSW_11_2_X_2020-05-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a73f7b/6639/summary.html

Comparison Summary:

  • You potentially added 7377 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780700
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link

+1

@silviodonato
Copy link

@smuzaffar
Copy link
Contributor

smuzaffar commented May 29, 2020

+externals
@silviodonato , once this is merged then bot will automatically open a cmsdist PR with correct changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 775857c into cms-data:master May 29, 2020
@fabiocos fabiocos deleted the fc-mtdUnitTest branch July 20, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants