[Bugfix #568] Fix pr_exists check for merged PRs - #571
Merged
waleedkadous merged 2 commits intoFeb 26, 2026
Conversation
Contributor
Author
Architect ReviewLow-risk bugfix. Adds Architect review |
waleedkadous
deleted the
builder/bugfix-568-pr-exists-porch-check-fails-wh
branch
February 26, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #568
Root Cause
The
pr_existsporch check usesgh pr listwhich defaults to--state open. When a PR is merged before the gate is approved (e.g. architect approves late), the check returns 0 results and blocks the gate.Fix
Added
--state allto thepr_existscheck command in all 6 protocol.json files (3 incodev-skeleton/, 3 incodev/) so the check finds PRs regardless of state (open, merged, or closed).Files changed:
codev-skeleton/protocols/spir/protocol.jsoncodev-skeleton/protocols/air/protocol.jsoncodev-skeleton/protocols/aspir/protocol.jsoncodev/protocols/spir/protocol.jsoncodev/protocols/air/protocol.jsoncodev/protocols/aspir/protocol.jsonTest Plan
--state allin pr_exists checks--state alladded aftergh pr list)