test: skip real-agy e2e smoke pending #1323 - #1324
Merged
Merged
Conversation
The suite spawns the real Antigravity CLI; when agy is unauthenticated each spawn opens an OAuth browser window on the developer's machine before the skip-guard can detect the state. With ~10 builders running the CLI suite at phase checks, an agy re-auth (e.g. the 1.1.9 update) turns every local run into a window burst. Stopgap requested by the human; the proper fix (pin a fake agy across all suites) is in flight under #1323, which should re-enable this coverage.
waleedkadous
added a commit
that referenced
this pull request
Aug 1, 2026
Records the two repeated failure patterns from phase 1's eight review rounds (artifacts asserting something adjacent to the real thing; fixes correct about the mechanism but incomplete about its lifetime), and the one cheap check that catches both. Also the 1273 coordination: their _lastInputAt datum was false and retracted; the merge surface measured rather than guessed; and their correction that adopting #1320 is a replacement, not a deletion. Merge of origin/main (architect-directed, PR #1324 stops agy e2e opening OAuth windows on the human's machine) previewed clean and applied. #1320 had not landed, so no adoption triggered. Re-ran my own suites explicitly rather than trusting the aggregate: 186 Spec 1307 + 48 core green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
agy-integration.e2e.test.tsdeliberately spawns the real Antigravity CLI. When agy is unauthenticated, each spawn opens an OAuth browser window before the test's own skip-guard can detect the state — the guard reads the OAuth marker from output that arrives only after the window is open. With ~10 active builders runningtest:e2e:cliat phase checks, yesterday's agy 1.1.9 update (which forced re-auth) turned local suite runs into the login-window burst reported this morning.Fix
describe.skipon the one real-agy suite (3 tests), with a comment pointing at #1323. No other test in the CLI lane reaches a real agy (consult.e2e.test.tsonly exercises--help; the unit consult suite mockschild_process).Testing
Skip-only change to a single test file; CI runs the same suites and will show the 3 tests as skipped.
Stopgap explicitly requested by the human. #1323 (builder in flight) delivers the real fix — fake-agy pin across all suites — and should re-enable this coverage.
🤖 Generated with Claude Code