Skip to content

Fix send-integration e2e flake: teardown budget asymmetry (10s afterAll vs 120s beforeAll) #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedkadous merged 1 commit into from
Jul 30, 2026
Merged

Fix send-integration e2e flake: teardown budget asymmetry (10s afterAll vs 120s beforeAll) #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/codev/src/agent-farm/__tests__/send-integration.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,12 @@ describe('send integration (POST /api/send → /ws/messages)', () => {
// Guard against setup failure — variables may be undefined
if (workspaceA) {
const encA = encodeWorkspacePath(workspaceA);
await fetch(`http://localhost:${TEST_TOWER_PORT}/api/workspaces/${encA}/deactivate`, { method: 'POST' }).catch(() => {});
await fetch(`http://localhost:${TEST_TOWER_PORT}/api/workspaces/${encA}/deactivate`, { method: 'POST', signal: AbortSignal.timeout(10_000) }).catch(() => {});
cleanupWorkspace(workspaceA);
}
if (workspaceB) {
const encB = encodeWorkspacePath(workspaceB);
await fetch(`http://localhost:${TEST_TOWER_PORT}/api/workspaces/${encB}/deactivate`, { method: 'POST' }).catch(() => {});
await fetch(`http://localhost:${TEST_TOWER_PORT}/api/workspaces/${encB}/deactivate`, { method: 'POST', signal: AbortSignal.timeout(10_000) }).catch(() => {});
cleanupWorkspace(workspaceB);
}

Expand All @@ -270,7 +270,10 @@ describe('send integration (POST /api/send → /ws/messages)', () => {
try { rmSync(`${dbBase}.db`, { force: true }); } catch { /* ignore */ }
try { rmSync(`${dbBase}.db-wal`, { force: true }); } catch { /* ignore */ }
try { rmSync(`${dbBase}.db-shm`, { force: true }); } catch { /* ignore */ }
}, 10_000);
// 120s to match beforeAll — the old explicit 10s override was tighter than
// the two deactivate calls + stopServer's SIGTERM wait can guarantee on a
// loaded CI runner, and a slow teardown failed the whole green suite.
}, 120_000);

// ---- Single-workspace send tests ----

Expand Down
Loading