Fix #1079: pass prompts as agy --print values - #1081
Conversation
CMAP review
All required GitHub CI checks pass on the current head. |
Architect Integration ReviewRisk: Medium — 135 additions across 7 files, including shared Result: No blocking integration issues found.
Architect review is approved, conditional on the current-head CI rerun remaining green and explicit human approval of the Architect integration review |
|
PR gate is human-approved and CI is green. The contributor account lacks merge permission; a repository maintainer is requested to merge this PR. |
waleedkadous
left a comment
There was a problem hiding this comment.
Thank you for an excellent submission, Mohid. 🙏
Precise root cause, a minimal correct-by-construction fix at both call sites, and exactly the right test shape — asserting --print adjacency (the old tests were complicit in the bug) plus a guarded real-agy 1.0.10 contract test. This very likely revives the structured Gemini consult lane we've been routing around. Approved.
…1081, by @mohidmakhdoomi) Other-fixes bullet covering the argv-ordering bug that made every gemini consult silently deliver --sandbox as the prompt. Substantial resolution of the #1032 umbrella. External contributor (Mohid Makhdoomi, second contribution after PR #953 in v3.2.0). CHANGELOG.md (VSCode-specific) intentionally not updated: this is a CLI fix, the VSCode extension does not bundle the consult code.
Brings the architect-curated release notes for v3.2.1 (4 substantive sections + 1 Polish + 1 Other-fixes entry) into main: - #1060 cross-file diff nav (PR #1067) - #1053 typography tokens (PR #1071) - #1066 sidebar auto-reveal (PR #1075) - #1074 backlog issue-preview placement, Polish (PR #1076) - #841 Add Architect UI, Cmd+K A picker (PR #1082) - #1079 agy --print prompt-delivery fix, Other fixes (PR #1081 by @mohidmakhdoomi) PR #1084 (issue #1072 refactor) intentionally omitted from changelog per feedback_skip_changelog_for_pure_refactor.
…s section Two corrections to v3.2.1 release notes: 1. Mohid Makhdoomi has 5 prior PRs to Codev (#741, #904, #923, #953, #1081), not 2. Was incorrectly cited as 'second contribution' in v3.2.1 release summary and projectlist entry; now corrected to 'fifth contribution'. 2. The Contributors section was inadvertently left as the template placeholder during Step 2 of the v3.2.1 release. Now populated with the topic-first format matching v3.2.0 precedent, crediting @amrmelsayed for VS Code extension features across 6 PRs and @mohidmakhdoomi for the agy --print argv fix.
Two complementary fixes for the agy/Gemini consult lane, recovered from in-progress work and rebased on top of the cluesmith#1081 argv-ordering fix: - consult: prepend a read-only headless-mode constraint preamble to the agy prompt so it stops exploring dirs/git, activating local skills (e.g. google-antigravity-sdk), and wandering off-task — and is told to end with a parseable VERDICT line. Delivered on both the inline and large-prompt temp-file paths. (cluesmith#1032) - porch: a consult that ran but produced no parseable VERDICT now defaults to COMMENT (non-blocking) instead of REQUEST_CHANGES, so a missing verdict no longer churns the porch review loop. (cluesmith#1033)
Summary
Correct Antigravity CLI argument ordering so Gemini consultations and the doctor probe deliver their intended prompts instead of option names.
Fixes #1079
Root Cause
agy1.0.10 treats--printas a string-valued option. Codev placed--sandboxor--print-timeoutimmediately after it, so those option tokens became the prompt while the real consultation/probe text was left as a trailing positional argument.Fix
--print <prompt>pair in both consultation and doctor paths.pro, prompt files, folded structured content, large-prompt indirection, and the doctor probe.Test Plan
pnpm buildpnpm test -- --run(3339 passed, 48 skipped)gemini,pro, and--prompt-filefront doors return exact markers