[Bugfix #1022] Exclude .builders/node_modules from VSCode watch/search; drop test-runner recommendation - #1039
Merged
Merged
Conversation
…search, drop test-runner recommendation - Add files.watcherExclude and extend search.exclude in .vscode/settings.json with **/.builders/** and **/node_modules/** so VSCode and any tool it drives stop walking the builder worktree farm - Remove ms-vscode.extension-test-runner from .vscode/extensions.json recommendations (its discovery runs rg --no-ignore --follow over the whole tree, pegging CPU on workspaces with builder worktrees) - Update packages/vscode/vsc-extension-quickstart.md to match the actual recommendations and note why the test runner is install-on-demand - Add regression test guarding both config invariants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1022
Problem
Opening the repo in VSCode and accepting the recommended extensions installs
ms-vscode.extension-test-runner. Its test discovery runsrg --files --hidden --no-require-git --no-ignore --follow ..., which skips.gitignoreand chases symlinks, so on a workspace with builder worktrees it walks every.builders/*/node_modulespnpm symlink farm. With ~15 worktrees this spawns a flood ofrgprocesses and pegs CPU for ~30s at a time, recurring on file changes.Fix
.vscode/settings.json: addfiles.watcherExcludeand extendsearch.excludewith**/.builders/**and**/node_modules/**. Defense-in-depth: any tool VSCode drives (search, quick-open, other extensions) stops traversing the worktree farm..vscode/extensions.json: removems-vscode.extension-test-runnerfrom recommendations.dbaeumer.vscode-eslintandconnor4312.esbuild-problem-matchersare kept; the file stays.packages/vscode/vsc-extension-quickstart.md: the setup line now lists the actual recommended extensions (it previously also namedamodio.tsl-problem-matcher, which was never inextensions.json), and the "Run tests" section notes the test runner is install-on-demand and why.Regression test
packages/codev/src/__tests__/bugfix-1022-vscode-dev-config.test.tsguards both invariants: the test-runner extension is never re-recommended, and.builders/node_modulesstay excluded from both watcher and search.Verification
porch check: build ✓, full test suite ✓.🤖 Generated with Claude Code