Problem
Consult builds a reviewer's changed-file scope from the tracked diff, so untracked files — typically brand-new test files — are invisible to reviewers even though they exist in the worktree.
In SPIR project 1216 (PR #1231, external contributor), this caused three false-positive REQUEST_CHANGES across two phases (Codex twice, Gemini once): the required tests existed on disk the whole time, but the generated changed-file list omitted them, so reviewers reported missing coverage. Each false positive cost a full consultation iteration plus a written rebuttal.
Proposal
Either (builder's choice at implementation time):
- Include intended untracked files in the review scope (detect via
git status), or
- Warn loudly before the consultation runs, listing untracked files that fall outside the scope, so the builder stages/commits first.
Option 2 is the minimal safe fix; option 1 needs care not to sweep in harness/scratch files.
Provenance
Surfaced in the spir-1216 builder's review artifact (Methodology Improvements / Follow-up Items), codev/reviews/1216-configurable-porch-gate-artifact-auto-open.md.
Problem
Consult builds a reviewer's changed-file scope from the tracked diff, so untracked files — typically brand-new test files — are invisible to reviewers even though they exist in the worktree.
In SPIR project 1216 (PR #1231, external contributor), this caused three false-positive REQUEST_CHANGES across two phases (Codex twice, Gemini once): the required tests existed on disk the whole time, but the generated changed-file list omitted them, so reviewers reported missing coverage. Each false positive cost a full consultation iteration plus a written rebuttal.
Proposal
Either (builder's choice at implementation time):
git status), orOption 2 is the minimal safe fix; option 1 needs care not to sweep in harness/scratch files.
Provenance
Surfaced in the spir-1216 builder's review artifact (Methodology Improvements / Follow-up Items),
codev/reviews/1216-configurable-porch-gate-artifact-auto-open.md.