Skip to content

chore: user-agent reports extension version instead of vscode version#38

Merged
colinmoynes merged 1 commit intomainfrom
chore/user-agent-version
Apr 2, 2026
Merged

chore: user-agent reports extension version instead of vscode version#38
colinmoynes merged 1 commit intomainfrom
chore/user-agent-version

Conversation

@DevonL
Copy link
Copy Markdown
Collaborator

@DevonL DevonL commented Mar 31, 2026

  • Chore: user-agent reports extension version instead of vscode version

📄 Summary

Briefly describe the purpose of this pull request. What problem does it solve or feature does it add?

🔍 Related Issues

Link to any related GitHub issues (e.g., Fixes #12, Closes #34):

🧪 Type of Change

Please check the relevant type tag for this PR title:

  • [FIX] Bug fix
  • [NEW] New thing
  • [REFACTOR] Internal changes such as code restructuring or optimization that does not alter functionality
  • [DOC] Documentation-only changes
  • [CHORE] Maintenance, cleanup, or CI configuration

🧪 How Has This Been Tested?

Describe how you tested your changes. Include CI runs, local tests, manual verification, or screenshots if applicable.

📸 Screenshots (if applicable)

If UI or logs are affected, include before/after screenshots or output.

✅ Checklist

  • I’ve read and followed the CONTRIBUTING.md.
  • I’ve added or updated documentation as needed.
  • I’ve verified the change is tested and works as intended.
  • CI/CD checks pass and do not break existing functionality.
  • My code follows the style guidelines of this project.

Copilot AI review requested due to automatic review settings March 31, 2026 18:43
@DevonL DevonL requested a review from colinmoynes as a code owner March 31, 2026 18:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is a maintenance PR that refactors the user-agent string construction in the CloudsmithAPI module. The changes improve code organization by extracting the extension version and constructing the user-agent string at module initialization time, rather than loading the entire package.json object and constructing the string inline on each request.

Changes:

  • Extract just the version from package.json instead of loading the entire object
  • Create a module-level constant for the user-agent string
  • Use the new constant when setting the User-Agent header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@colinmoynes colinmoynes merged commit a190673 into main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants