Skip to content

Discard faulty params #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pereirinha merged 1 commit into from
Sep 17, 2024
Merged

Discard faulty params #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions php/traits/trait-params.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,15 @@ protected function set_param_array( $parts, $param, $value ) {
return $new;
}

if ( '' === $key ) {
$new[] = $value;
if ( is_array( $new ) ) {
if ( '' === $key ) {
$new[] = $value;
} else {
$new[ $key ] = $value;
}
} else {
$new[ $key ] = $value;
// There's likely a problem here, as we're setting an array key on a non-array.
$new = array();
}
// @TODO: I took ksort out, need to check that it doesn't have any problems being.

Expand Down