Merged
Conversation
DavidCramer
approved these changes
May 19, 2020
Contributor
DavidCramer
left a comment
DavidCramer
left a comment
There was a problem hiding this comment.
@pereirinha - Looks good. Just a single note about a forward slash, otherwise all good!
| <span id="progress-wrapper" class="sync-media-progress"> | ||
| <span class="progress-text"><span id="sync-progress"></span> / <span id="sync-total"></span></span><?php esc_html_e( 'Currently Synced', 'cloudinary' ); ?> | ||
| <span class="progress-text"> | ||
| <img src="<?php echo esc_url( CLDN_URL . '/css/loading.svg'); ?>" alt="<?php esc_attr_e( 'Syncing…', 'cloudinary' ); ?>"> |
Contributor
There was a problem hiding this comment.
@pereirinha CLDN_URL ends with a / already, so we get a double //
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the visual feedback of the bulk sync action.
Instead of showing feedback of the many assets to be sync — as it can be inaccurate information —, we'll show an icon instead to reflect the sync action.
This PR also removes the number of requests made on this page.