Makes the "Overwrite Transformations" toggle visible if there's meta entries for transformations#38
Conversation
added 8 commits
January 24, 2020 20:12
kienstra
reviewed
Jan 28, 2020
Contributor
kienstra
left a comment
kienstra
left a comment
There was a problem hiding this comment.
Looks good
Hi @dugajean,
Nice work, there are a few small points below.
It'd be great if @DavidCramer had a chance to look at this from a high level at least.
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-plugin.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-filter.php
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Show resolved
Hide resolved
Contributor
|
@dugajean , @kienstra , |
parabrola
changed the title
parabrola
changed the title
Contributor
Author
|
@asisayag2 Hi Asi! Thanks for sharing that info. For the code conventions I presume on |
Contributor
|
@dugajean, code conventions are important, but in my comment I meant the PR convention - how we call it and what should/shouldn't be in its title |
kienstra
suggested changes
Jan 29, 2020
Contributor
kienstra
left a comment
kienstra
left a comment
There was a problem hiding this comment.
Almost done 😄
Hi @dugajean,
This is looking good, there are just some minor points below.
Nice work.
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-plugin.php
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-filter.php
Show resolved
Hide resolved
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/media/class-filter.php
Outdated
Show resolved
Hide resolved
kienstra
reviewed
Jan 29, 2020
cloudinary-image-management-and-manipulation-in-the-cloud-cdn/js/src/components/video.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kienstra Applied the latest remarks! |
kienstra
approved these changes
Jan 29, 2020
Contributor
kienstra
left a comment
kienstra
left a comment
There was a problem hiding this comment.
Approved
Hi @dugajean,
This looks good. I think it's ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are certain cases when you pull an image down from the Cloudinary tab, it will also add the
_transformationsmetadata for the attachment, which then makes the toggle visible again.