Skip to content

types: use more proper type to derive CldVideoPlayerProps #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colbyfayock merged 2 commits into from
Oct 14, 2024
Merged

types: use more proper type to derive CldVideoPlayerProps #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa4b81
types: use more proper type to derive `CldVideoPlayerProps`
Andarist Oct 4, 2024
2c9da7a
Merge branch 'main' into fix/use-more-direct-type
colbyfayock Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const CldVideoPlayer = (props: CldVideoPlayerProps) => {
onPlay,
onEnded,
width,
} = props as CldVideoPlayerProps;
} = props;

const uniqueId = useId();

Expand Down
7 changes: 3 additions & 4 deletions next-cloudinary/src/components/CldVideoPlayer/CldVideoPlayer.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import { MutableRefObject } from 'react';
import {
CloudinaryVideoPlayer,
CloudinaryVideoPlayerOptionsLogo,
CloudinaryVideoPlayerOptions
} from '@cloudinary-util/types';
import { ConfigOptions } from "@cloudinary-util/url-loader";
import { ConfigOptions, GetVideoPlayerOptions } from "@cloudinary-util/url-loader";

import { GetCldImageUrlOptions } from '../../helpers/getCldImageUrl';
import { GetCldVideoUrlOptions } from '../../helpers/getCldVideoUrl';

export type CldVideoPlayerProps = Omit<CloudinaryVideoPlayerOptions, "cloud_name" | "autoplayMode" | "publicId" | "secure" | "showLogo" | "logoImageUrl" | "logoOnclickUrl"> & {
export type CldVideoPlayerProps = Omit<GetVideoPlayerOptions, "cloud_name" | "autoplayMode" | "publicId" | "secure" | "showLogo" | "logoImageUrl" | "logoOnclickUrl"> & {
Comment thread
colbyfayock marked this conversation as resolved.
className?: string;
config?: ConfigOptions;
id?: string;
Expand All @@ -31,4 +30,4 @@ export interface CldVideoPlayerPropsLogo {
imageUrl?: CloudinaryVideoPlayerOptionsLogo['logoImageUrl'];
logo?: boolean;
onClickUrl?: CloudinaryVideoPlayerOptionsLogo['logoOnclickUrl'];
}
}