fix(miniflare): disable per-browser SIGINT/SIGHUP to allow full multi-session teardown (Closes #15419)

[ravendevhub]

Fixes #15419

Summary

When a local Browser Rendering Worker has more than one active Chrome session, sending SIGINT directly to the Wrangler Node process terminates Wrangler and kills only the first Chrome process tree, leaving remaining Chrome process trees orphaned (reparented to PID 1).

Solution

• Explicitly passed handleSIGINT: false and handleSIGHUP: false to @puppeteer/browsers's launch() options in packages/miniflare/src/plugins/browser-rendering/index.ts.
• In Miniflare's exitHook in packages/miniflare/src/index.ts, synchronously terminate all tracked active browser processes in #browserProcesses before the process exits.
• Added patch changeset in .changeset/fix-browser-rendering-sigint.md.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because: Disables per-process signal handling in @puppeteer/browsers to allow Miniflare's centralized exitHook teardown to manage process lifecycle.
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: Internal process lifecycle and signal handling fix in Miniflare.

[changeset-bot]

🦋 Changeset detected

Latest commit: 440c633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
miniflare	Patch
@cloudflare/deploy-helpers	Patch
@cloudflare/pages-shared	Patch
@cloudflare/remote-bindings	Patch
@cloudflare/runtime-types	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-plugin	Patch
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/wrangler

Show detailed file reviewers

• .changeset/fix-browser-rendering-sigint.md: [@cloudflare/wrangler]
• packages/miniflare/src/index.ts: [@cloudflare/wrangler]
• packages/miniflare/src/plugins/browser-rendering/index.ts: [@cloudflare/wrangler]

[pkg-pr-new]

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15431

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15431

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15431

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15431

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15431

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15431

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15431

miniflare

npm i https://pkg.pr.new/miniflare@15431

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15431

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15431

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15431

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15431

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15431

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15431

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15431

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15431

wrangler

npm i https://pkg.pr.new/wrangler@15431

commit: 440c633

[petebacondarwin]

Requesting changes because browser processes that are still launching are not covered by the new teardown path.

Puppeteer signal handling is disabled before launchBrowser() completes, but Miniflare does not register the process with its exit hook until after that function returns. If SIGINT or SIGHUP arrives during concurrent launches, those processes are invisible to the Miniflare hook and a detached browser child can survive.

Please track every process immediately when it is launched, including retry attempts, and unregister it on exit or launch failure. Add regression coverage for multiple established sessions and concurrent pending launches under SIGINT and SIGHUP.

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/wrangler

Show detailed file reviewers

• .changeset/fix-browser-rendering-sigint.md: [@cloudflare/wrangler]
• packages/miniflare/src/index.ts: [@cloudflare/wrangler]
• packages/miniflare/src/plugins/browser-rendering/index.ts: [@cloudflare/wrangler]