[miniflare] fix: emit valid SQL literal for Infinity/-Infinity in D1 export by manthaaaaan · Pull Request #15420 · cloudflare/workers-sdk

manthaaaaan · 2026-08-29T16:01:33Z

Fixes #15378 (partially — the Infinity/-Infinity bare-identifier bug only. The int64 precision issue reported in the same issue is a separate, larger fix that needs its own discussion, since the value loses precision upstream before this code even runs.)

What this fixes

When a REAL column contained Infinity or -Infinity, dumpSql emitted the raw JavaScript string representation ("Infinity" / "-Infinity") directly into the generated SQL. SQLite doesn't recognize these as numeric literals — it parses them as bare identifiers — so re-importing D1's own export failed with: "no such column: Infinity at offset 45: SQLITE_ERROR"

The fix

In packages/miniflare/src/workers/d1/dumpSql.ts, non-finite numbers are now detected and emitted as 9e999 / -9e999 instead of their raw JS string form. This matches the approach SQLite's own .dump command uses — 9e999 is a valid numeric literal that overflows to Infinity on parse, so it round-trips correctly.

Testing

Added a new test, "dumpSql exports Infinity and -Infinity as valid, re-importable SQL literals", in packages/miniflare/test/plugins/d1/suite.ts. It:

Creates a table with a REAL column and inserts Infinity and -Infinity
Exports via the PRAGMA miniflare_d1_export pragma
Asserts the dump does not contain the raw Infinity/-Infinity tokens as bare identifiers
Re-imports the dump into a fresh database and confirms it succeeds
Confirms the re-imported values are exactly Infinity and -Infinity

Test passes locally (pnpm test suite.ts -t "Infinity"), and the full build passes with no new type errors.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: internal bug fix to SQL literal generation; no user-facing behavior, config, or docs change.

A picture of a cute animal (not mandatory, but encouraged)

…export

changeset-bot · 2026-08-29T16:01:38Z

🦋 Changeset detected

Latest commit: 3d7b298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
miniflare	Patch
@cloudflare/deploy-helpers	Patch
@cloudflare/pages-shared	Patch
@cloudflare/remote-bindings	Patch
@cloudflare/runtime-types	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-plugin	Patch
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-08-29T16:01:58Z

Codeowners approval required for this PR:

@cloudflare/wrangler

Show detailed file reviewers

.changeset/fix-d1-export-infinity.md: [@cloudflare/wrangler]
packages/miniflare/src/workers/d1/dumpSql.ts: [@cloudflare/wrangler]
packages/miniflare/test/plugins/d1/suite.ts: [@cloudflare/wrangler]

devin-ai-integration

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

pkg-pr-new · 2026-08-29T16:04:56Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15420

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15420

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15420

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15420

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15420

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15420

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15420

miniflare

npm i https://pkg.pr.new/miniflare@15420

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15420

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15420

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15420

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15420

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15420

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15420

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15420

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15420

wrangler

npm i https://pkg.pr.new/wrangler@15420

commit: 3d7b298

dario-piotrowicz

Thanks for the fix @manthaaaaan 😄

Looks good to me, beside some small suggestions 🙂

dario-piotrowicz · 2026-09-10T13:45:14Z

+	const [dumpStatements] = result as [string[]];
+	const dump = dumpStatements.join("\n");
+
+	// The dump must not contain the raw JS token as a bare identifier


Suggested change

// The dump must not contain the raw JS token as a bare identifier

// The dump must not contain the raw JS Infinity/-Infinity tokens as bare identifiers

dario-piotrowicz · 2026-09-10T13:47:02Z

+	// exec(dump) must not throw — this is the core guarantee of the fix.
+	// (If the dump contained bare `Infinity`/`-Infinity` identifiers, SQLite
+	// would reject them at parse time and exec would throw.)


outside of the context of this PR the sentence "this is the code guarantee of the fix" doesn't have any meaning

I would simplify this comment:

Suggested change

// exec(dump) must not throw — this is the core guarantee of the fix.

// (If the dump contained bare `Infinity`/`-Infinity` identifiers, SQLite

// would reject them at parse time and exec would throw.)

// exec(dump) must not throw, If the dump contained the bare `Infinity`/`-Infinity`

// identifiers, SQLite would reject them at parse time and exec would throw

dario-piotrowicz · 2026-09-10T13:48:08Z

+	// Assert the exported SQL actually contains the correctly-signed literal
+	// for each row — this is the real guarantee of the fix, checked before
+	// the D1 JS binding's Infinity->null normalisation can hide it.


as above, I would really avoid mentioning "the fix":

Suggested change

// Assert the exported SQL actually contains the correctly-signed literal

// for each row — this is the real guarantee of the fix, checked before

// the D1 JS binding's Infinity->null normalisation can hide it.

// Assert the exported SQL actually contains the correctly converted value for each row

workers-devprod · 2026-09-10T13:49:46Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

workers-devprod

Codeowners reviews satisfied

manthaaaaan added 2 commits August 29, 2026 21:18

[miniflare] fix: emit valid SQL literal for Infinity/-Infinity in D1 …

f4524f0

…export

[miniflare] fix: emit valid SQL literal for Infinity/-Infinity in D1 …

73c22ad

…export

manthaaaaan requested a review from workers-devprod as a code owner August 29, 2026 16:01

workers-devprod added this to workers-sdk Aug 29, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Aug 29, 2026

workers-devprod requested review from a team and emily-shen and removed request for a team August 29, 2026 16:01

devin-ai-integration Bot reviewed Aug 29, 2026

View reviewed changes

manthaaaaan added 4 commits August 29, 2026 22:01

Add changeset

f10b2b1

Assert exact signed literal in dump, per review feedback

5c72c06

Fix formatting

5a10ac9

Merge remote-tracking branch 'origin/main' into fix/d1-export-infinity

3d7b298

dario-piotrowicz requested review from dario-piotrowicz and removed request for emily-shen September 10, 2026 13:38

dario-piotrowicz approved these changes Sep 10, 2026

View reviewed changes

workers-devprod approved these changes Sep 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

[miniflare] fix: emit valid SQL literal for Infinity/-Infinity in D1 export - #15420

[miniflare] fix: emit valid SQL literal for Infinity/-Infinity in D1 export#15420
manthaaaaan wants to merge 6 commits into
cloudflare:mainfrom
manthaaaaan:fix/d1-export-infinity

manthaaaaan commented Aug 29, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

changeset-bot Bot commented Aug 29, 2026 •

edited

Loading

Uh oh!

workers-devprod commented Aug 29, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

pkg-pr-new Bot commented Aug 29, 2026 •

edited

Loading

Uh oh!

dario-piotrowicz left a comment

Uh oh!

dario-piotrowicz Sep 10, 2026

Uh oh!

dario-piotrowicz Sep 10, 2026

Uh oh!

dario-piotrowicz Sep 10, 2026

Uh oh!

workers-devprod commented Sep 10, 2026

Uh oh!

workers-devprod left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// The dump must not contain the raw JS token as a bare identifier
	// The dump must not contain the raw JS Infinity/-Infinity tokens as bare identifiers

Uh oh!

Conversation

manthaaaaan commented Aug 29, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this fixes

The fix

Testing

Uh oh!

changeset-bot Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

🔍 Devin Review: 1 flag

Uh oh!

pkg-pr-new Bot commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

workers-devprod commented Sep 10, 2026

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manthaaaaan commented Aug 29, 2026 •

edited by devin-ai-integration Bot

Loading

changeset-bot Bot commented Aug 29, 2026 •

edited

Loading

workers-devprod commented Aug 29, 2026 •

edited

Loading

pkg-pr-new Bot commented Aug 29, 2026 •

edited

Loading