Repository navigation
Miniflare config followups - #15130
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a6d4072 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
Contributor
|
No deploy-time reliance on workflow
I've reviewed both commits thoroughly. The changes are consistent, all references are cleaned up, downstream code degrades gracefully, and the tests properly cover the new warning behavior. No logic bugs, security issues, backward-compat violations, or incorrect API behavior found. LGTM |
emily-shen
force-pushed
the
emily/miniflare-fixups
branch
from
August 12, 2026 11:11
deb7e00 to
a990bc3
Compare
emily-shen
force-pushed
the
emily/miniflare-fixups
branch
from
August 12, 2026 11:11
a990bc3 to
ad7762d
Compare
emily-shen
force-pushed
the
emily/miniflare-fixups
branch
from
August 12, 2026 14:15
ad7762d to
1cfafe6
Compare
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
emily-shen
marked this pull request as ready for review
August 12, 2026 14:48
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
August 12, 2026 14:49
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
edmundhung
approved these changes
Aug 17, 2026
workers-devprod
approved these changes
Aug 17, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
emily-shen
commented
Aug 18, 2026
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
emily-shen
enabled auto-merge (squash)
August 18, 2026 14:33
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit contains a fixup
namerequried for AE binding - workerd requires this, but it is not required at deploy time i think? either way, to prevent workerd crashing, we set a default.A picture of a cute animal (not mandatory, but encouraged)