Repository navigation
deps: bump miniflare to 4.20260329.0 and remove undici dependency - #959
Merged
Merged
Conversation
Use miniflare's built-in createFetchMock instead of undici's MockAgent. Update durable object tests to use state.id().name() directly now that workerd#2240 is fixed, removing the QueryParams workaround.
Merging this PR will not alter performance
|
Member
|
It seems this is breaking the containers tests, so I'm unable to land it unfortunately. We might need to rework how those behave further. |
Member
|
I've gone ahead and just disabled the containers tests for now, we can follow-up separately with figuring out the containers test coverage. |
guybedford
previously approved these changes
Apr 1, 2026
guybedford
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use miniflare's built-in createFetchMock instead of undici's MockAgent. Update durable object tests to use state.id().name() directly now that workerd#2240 is fixed, removing the QueryParams workaround.