Skip to content

deps: bump miniflare to 4.20260329.0 and remove undici dependency - #959

Merged
guybedford merged 10 commits into
cloudflare:mainfrom
connyay:cjh-bump-miniflare
Apr 1, 2026
Merged

guybedford merged 10 commits into
cloudflare:mainfrom
connyay:cjh-bump-miniflare

Conversation

@connyay

@connyay connyay commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Use miniflare's built-in createFetchMock instead of undici's MockAgent. Update durable object tests to use state.id().name() directly now that workerd#2240 is fixed, removing the QueryParams workaround.

Use miniflare's built-in createFetchMock instead of undici's MockAgent.
Update durable object tests to use state.id().name() directly now that
workerd#2240 is fixed, removing the QueryParams workaround.
@codspeed

codspeed Bot commented Apr 1, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 2 untouched benchmarks


Comparing connyay:cjh-bump-miniflare (f6fbcb3) with main (fc48d66)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (6d6d5a8) during the generation of this report, so fc48d66 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@guybedford

Copy link
Copy Markdown
Member

It seems this is breaking the containers tests, so I'm unable to land it unfortunately. We might need to rework how those behave further.

@guybedford

Copy link
Copy Markdown
Member

I've gone ahead and just disabled the containers tests for now, we can follow-up separately with figuring out the containers test coverage.

guybedford
guybedford previously approved these changes Apr 1, 2026
@guybedford
guybedford merged commit 4b86082 into cloudflare:main Apr 1, 2026
18 of 19 checks passed
@connyay
connyay deleted the cjh-bump-miniflare branch April 20, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants