Skip to content

Enable CLA Assistant on this repo - #55

Merged
kentonv merged 1 commit into
cloudflare:mainfrom
larcher:main
Sep 30, 2022
Merged

kentonv merged 1 commit into
cloudflare:mainfrom
larcher:main

Conversation

@larcher

@larcher larcher commented Sep 29, 2022

Copy link
Copy Markdown

With the CLA Assistant able, when a PR is opened it will check if the person has signed the CLA before, and if not, add a comment like this:
image

The link there goes to https://www.cloudflare.com/cla/

  • Signatures will be stored in a file in this repo: signatures/version1/cla.json (this is configurable, and could even be in a separate repo)
  • For users or bots who should not be required to sign the CLA, there's an allowlist: option in this file.
  • There's currently no way to make an exception for "trivial changes" (fixing typos, etc)

@jasnell jasnell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we absolutely have to, then ...grrr... ok.
Would absolutely prefer not to have a CLA tho.

@kentonv
kentonv merged commit bcf3e4b into cloudflare:main Sep 30, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants