Repository navigation
Pass a jsg::Lock to wrap and unwrap so we can get the isolate from it - #4244
Merged
Merged
Conversation
Contributor
|
The total size of the files in this PR is too large. |
erikcorry
changed the title
|
The generated output of |
erikcorry
force-pushed
the
erikcorry/wrap-unwrap-with-lock
branch
from
June 4, 2025 11:59
9eb09d6 to
7ac507e
Compare
jasnell
reviewed
Jun 4, 2025
This doesn't compile. Something to do with CompatibilityFlags::Reader.
erikcorry
force-pushed
the
erikcorry/wrap-unwrap-with-lock
branch
from
June 10, 2025 12:24
eccc68a to
ce30c20
Compare
jasnell
approved these changes
Jun 10, 2025
jasnell
left a comment
jasnell
left a comment
Collaborator
There was a problem hiding this comment.
Overall LGTM (though I recognize there still might be some details remaining to get it to pass CI before it lands)
erikcorry
added a commit
that referenced
this pull request
Jun 10, 2025
…#4244) * Pass a jsg::Lock to wrap and unwrap so we can get the isolate from it In #4208 we reduced the use of context->GetCurrent since is is only a wrapper around v8::Isolate::GetCurrent. However, discussion there raised the issue that v8::Isolate::GetCurrent is potentially slow and messy since it gets the isolate from thread-local storage. It was agreed that it would be better to pass the jsg::Lock (which has the isolate) to those functions that need it. This change implements that suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4208 we reduced the use of context->GetCurrent since is is only a wrapper around v8::Isolate::GetCurrent.
However, discussion there raised the issue that v8::Isolate::GetCurrent is potentially slow and messy since it gets the isolate from thread-local storage. It was agreed that it would be better to pass the jsg::Lock (which has the isolate) to those functions that need it. This change implements that suggestion.