Repository navigation
Break actor on errors that rollback transactions - #3832
Conversation
714c2bb to
eb1101f
Compare
|
See #3832 for context |
|
All contributors have signed the CLA ✍️ ✅ |
4309615 to
23db545
Compare
kentonv
left a comment
There was a problem hiding this comment.
OK, at this point I just have straightforward comments. Yay!
But, what about an end-to-end test? I don't see any here nor in the internal repo. Can we test this somehow? Maybe using an SRS testDirective to inject an error?
a40f9d7 to
16370fc
Compare
8602b85 to
f1ac228
Compare
f1ac228 to
b9b0735
Compare
|
LGTM, just needs the fixups squashed and the internal test. |
5a611d4 to
ce5670c
Compare
4d18cba to
d9466ba
Compare
|
The generated output of |
112390b to
20082fd
Compare
b556f35 to
4452aea
Compare
4452aea to
532a983
Compare
|
@cloudflare/wrangler Could someone help review this PR so I can merge it? |
|
I bypassed codeowner check and merged. @danlapid why are our merges being blocked on review from the wrangler team? |
As a follow up to an incident of D1 a few weeks ago we set wrangler as a required CODEOWNER on types changes. The ANT team has historically been the one to maintain and own the types generation and the generated types and they have a better grasp of the possible implications of those changes. They are usually very quick to review but I suspect that due to Friday and Monday being bank holidays in the UK this pull request didn't get much attention. |
We should break output gates and reset actors in the event that we catch the following exceptions because they implicitly roll back any transaction:
SQLITE_FULL: database or disk full
SQLITE_IOERR: disk I/O error
SQLITE_BUSY: database in use by another process
SQLITE_NOMEM: out of memory
https://www.sqlite.org/lang_transaction.html#response_to_errors_within_a_transaction