fix(text): suppress production deprecation warnings - #751
Open
geoquant wants to merge 1 commit into
Open
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 516 files, 1.42 MB packed, 6.71 MB unpacked.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


























































































Summary
process.env.NODE_ENVasproductionduring Kumo's published JavaScript buildTextheading warnings in source while removing them from production bundlesContext
@cloudflare/kumo@2.12.0intended to guard deprecatedheading1–heading3warnings withprocess.env.NODE_ENV !== "production". During packaging, that condition was evaluated incorrectly and the published artifact contained an unconditionalconsole.warn.This fixes the issue at Kumo's package boundary rather than filtering warnings in consumers such as Stratus.
Validation
fresh uncached
@cloudflare/kumoproduction buildfull Kumo unit suite: 1,278 tests passed
Kumo lint
Kumo typecheck
changeset validation
verified the emitted production JavaScript contains neither the Text deprecation warning nor
process.env.NODE_ENVReviews
bonk has reviewed the change
automated review not possible because: this change requires review of build-time environment replacement and generated package behavior
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: not applicable
Additional testing not necessary because: not applicable