pki: return an error for schemes without an object identifier - #700
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bwesterb
self-requested a review
September 7, 2026 12:39
bwesterb
approved these changes
Sep 7, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four
pkimarshal functions assertedscheme.(CertificateScheme)to reach an object identifier, andMarshalPKIXPrivateKeyassertedsk.(sign.Seeded)for ML-DSA. A scheme without an OID panicked instead of returning the error the signature declares. Dilithium and SLH-DSA are registered insign/schemeswithout one, so this is reachable with the library's own keys.Each site now returns an error. The new test marshals a key of every registered scheme that lacks an OID through all four functions; on main it panics.