Repository navigation
fix(tasks): stale routed wake no longer throws Invalid job outcome - #2476
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 05bcbc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+1016
to
+1023
| it("returns no outcome for a routed Task wake whose owner facet is gone", async () => { | ||
| const name = uniqueName(); | ||
| const agent = await getAgentByName(env.TestSubAgentParent, name); | ||
|
|
||
| expect(await agent.driveStaleRoutedTaskWake("task_stale_direct")).toBe( | ||
| "undefined" | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
🔍 Regression test bypasses the alarm queue
The test calls tasks.onJob directly, without persisting a wake or driving an alarm. It cannot catch a failure when applyOutcome processes the result.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
|
✅ agents import sizes: no significant changes ( |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2467 (ask 1, the
Invalid job outcomethrow). Does not address the version-swap re-push question or arming the no-progress budget at spawn.routeLifecycleToTargetcleans the stale prefix and returnsfalse.Tasks.onJobpassed that straight toapplyOutcome, which throws on every alarm.onJobnow maps afalserouted reply toundefined, so the mirror job is deleted quietly.