Repository navigation
fix(think,ai-chat): raise agents peer floor to >=0.25.0 - #2408
Merged
Merged
Conversation
Both packages import helpers from agents/chat (isDurableObjectResetError, retryAfterSeconds, isLateToolInputChunk) that first ship in agents@0.25.0. The previous peer floors allowed installing these releases against an agents version missing those helpers, failing at runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: a1b68dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
✅ agents import sizes: no significant changes ( |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the
agentspeer dependency floor to>=0.25.0in both@cloudflare/thinkand@cloudflare/ai-chat.@cloudflare/think>=0.24.0 <1.0.0>=0.25.0 <1.0.0@cloudflare/ai-chat>=0.23.0 <1.0.0>=0.25.0 <1.0.0Why
Addresses the Devin review finding on the release PR #2335 (discussion_r4110536404): "Chat releases accept incompatible agents versions."
Both chat packages now import helpers from
agents/chatthat first ship inagents@0.25.0:isDurableObjectResetErrorretryAfterSecondsisLateToolInputChunkthinkimports all three (packages/think/src/think.ts);ai-chatimportsisDurableObjectResetError(packages/ai-chat/src/index.ts).With the old peer floors, a consumer could install these new chat releases against an older
agents(e.g.think@0.20.0+agents@0.24.0) that satisfies the range but does not export those helpers, failing at runtime. The workspace-linked release build doesn't catch this because it resolves the localagents, not a published one. Requiring>=0.25.0keeps the published package combinations compatible.@cloudflare/voiceandhono-agentsdo not import these helpers, so their peer ranges are unchanged.Changeset
Included (
patchfor both packages).Made with Cursor