Repository navigation
fix(agents): one root call per sub-agent broadcast, none without recipients (#2252) - #2399
Merged
threepointone merged 2 commits intoSep 28, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 52853b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
added this pull request to stack #2407
September 28, 2026 14:47
threepointone
marked this pull request as ready for review
September 28, 2026 14:49
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
threepointone
force-pushed
the
fix/2252-facet-broadcast-rpcs
branch
from
September 28, 2026 15:46
ceb270b to
a32aa3d
Compare
Contributor
|
✅ agents import sizes: no significant changes ( |
…pients (#2252) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
threepointone
force-pushed
the
fix/2252-facet-broadcast-rpcs
branch
from
September 28, 2026 16:54
a32aa3d to
52853b1
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2252.
Problem
Outside the client frame that started the work, every facet broadcast resolved the root through
getAgentByName()before calling_cf_broadcastToSubAgent. That resolution is an__unsafe_ensureInitializedround trip, so a streamed answer cost two billed root requests per chunk, and they ran one after the other.Fix
onStart()before serving the call. That is the case the extraensureInitializedcall was guarding.without. Until the mirror is hydrated, broadcasts go to the root as before, so an unknown mirror never drops a message.The issue also suggested batching broadcasts. I left that out: with at most one call per chunk, and none when nobody is listening, batching would change delivery timing and need a new RPC shape for a smaller gain.
Tests
sub-agent-rpc-bridge.test.tscounts root calls:onStart()before it serves a sub-agent call.