Repository navigation
fix(think): truncate older tool results after toModelOutput (#2014) - #2339
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1a13066 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
added this pull request to stack #2345
September 23, 2026 19:59
Contributor
🟡 agents import sizesMeasured 344 runtime imports as minified bundles. The primary size is gzip; raw minified size is included for diagnosis. An existing import growing by more than 10% is marked red. This report is informational.
Compared Changed imports (22)
All 344 current runtime imports
Reported by agent-think[bot]. |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
threepointone
marked this pull request as ready for review
September 23, 2026 20:32
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
threepointone
force-pushed
the
fix/2014-truncate-model-tool-outputs
branch
from
September 23, 2026 23:58
3bdba41 to
1a13066
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2014.
Think truncated older tool outputs on the stored UI messages, before
convertToModelMessagesran. A tool whosetoModelOutputvalidates its output (for example withoutputSchema.parse) then failed on the truncated shape, and the turn errored when an aged result was replayed.Think now truncates after conversion:
truncateOlderMessages(..., { toolOutputs: false })for the UI messages, then the newtruncateOlderToolResultson the model messages. Only text, error-text, json and error-json outputs (and text items inside content outputs) are shortened. Provider-executed tool parts are never truncated, since the provider re-parses them against its own schema.agents/chat:TruncateOptions.toolOutputs, newtruncateOlderToolResultsexport.truncate-older-messages.test.ts, and a Think test that replays an aged 40-row output through a validatingtoModelOutput(fails on main with the zod error).Out of scope: storage compaction above 1.8MB still uses shape-truncation.